Apply env_logger module filters on Dart & UniFFI binding loggers
#874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erdemyerebasmaz
force-pushed
the
logger
branch
2 times, most recently
from
b544d81
to
265f0d6
Compare
erdemyerebasmaz
changed the title
logger.rsenv_logger module filters on Dart & UniFFI binding loggers
erdemyerebasmaz
force-pushed
the
logger
branch
4 times, most recently
from
18a4b02
to
39d9220
Compare
erdemyerebasmaz
force-pushed
the
logger
branch
2 times, most recently
from
086d763
to
2bbebbb
Compare
|
Depends on:
|
roeierez
requested changes
Mar 25, 2024
| }); | ||
| } | ||
|
|
||
| pub struct UniFFILogger { |
There was a problem hiding this comment.
Why taking the specific loggers out of their specific crates?
Doesn't UniFFILogger belong to the sdk-bindings crate?
There was a problem hiding this comment.
Not necessarily, the loggers are not exposed through bindings.
I had brought them together to see the differences to find the root cause of the issue, and I prefer having them together, but we can bring them back to uniffi_bindings.rs & bindings.rs with little to no change.
If we expand upon logger settings as mentioned on #892, it would be hard to miss applying new changes on bindings when they are grouped together like this.
Dart, UniFFI & GlobalSDK logger's are moved under logger.rs .
- Create LevelFilter struct that's usable from bindings. - Add optional filter_level param to binding logger init & setters - Map models:LevelFilter to log::LevelFilter. - Set LevelFilter::TRACE as default filter level
Log `UNUSUAL` level node logs at `Error` level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue where env_logger's module filters were not applying to logs listened through Dart & UniFFI binding loggers.
Changelist:
env_loggermodule filterslogger.rsLevelFilterstruct that's usable from bindings.filter_levelparam to binding logger init & settersmodels:LevelFiltertolog::LevelFilter.LevelFilter::TRACEas default filter levelTODO: