Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out node logs below Info level #848

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

erdemyerebasmaz
Copy link
Collaborator

@erdemyerebasmaz erdemyerebasmaz commented Mar 23, 2024

Build iOSBuild AndroidRun CI

This PR applies filter level customization changes on logger from Breez SDK PR:

which addresses the issue raised on:

where we were receiving unwanted SDK module logs as the filtering mechanism previously did not apply to them on binding loggers.


Reducing default log level from CONFIG to INFO had unwanted side effects such as missing out on node logs as they were all emitted on Debug level on the SDK, corresponds to CONFIG level on app layer, which got addressed by increasing their level to Info but this is a temporary fix that did not address the underlying issue.

The logs that are coming from modules were still not filtered and we were missing out on helpful logs on Debug level across the SDK, notification extensions and app. Also, since notification extensions & SDK uses the same log stream, there was no way to differentiate between their filter levels. Which are all addressed by this & SDK PR.

Currently, we don't miss information from Debug level logs & unwanted SDK module logs are filtered out.


Changelist:

  • Filter out node logs below Debug level on extensions 872c81d
  • Filter out node logs below Debug level on app bb979ca
    • Increase default log level back to CONFIG from INFO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant