-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Email aliases implementation #27127
Open
arthuredelstein
wants to merge
9
commits into
master
Choose a base branch
from
issues/43115
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Email aliases implementation #27127
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
19a90a3
Email aliases implementation
arthuredelstein ce6ca42
npm run format
arthuredelstein 0fb4706
tidy up
arthuredelstein 068f12d
restrict to android for now
arthuredelstein 86d02e1
make strings available in bubble
arthuredelstein aace919
presubmit fix
arthuredelstein adb23a1
not on android right now
arthuredelstein 860015a
presubmit fix
arthuredelstein 809b021
fix curly brave position
arthuredelstein File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -326,13 +326,117 @@ | |
</if> | ||
|
||
<!-- Settings / Autofill --> | ||
<message name="IDS_SETTINGS_EMAIL_ALIASES_LABEL" desc="The label to show the Email Aliases page"> | ||
Email Aliases | ||
</message> | ||
<message name="IDS_SETTINGS_BRAVE_AUTOFILL_PRIVATE_WINDOWS_LABEL" desc="The label to enable autofill in private profiles"> | ||
Allow auto-fill in private windows | ||
</message> | ||
<message name="IDS_SETTINGS_BRAVE_AUTOFILL_PRIVATE_WINDOWS_DESC" desc="The description for the label to enable autofill in private profiles"> | ||
Info from regular windows can be read/auto-filled in private windows | ||
</message> | ||
|
||
<!-- Settings / Email Aliases --> | ||
<message name="IDS_SETTINGS_EMAIL_ALIASES_SHORT_DESCRIPTION" desc="The short description for the Email Aliases page"> | ||
Keep your personal email address private | ||
</message> | ||
<message name="IDS_SETTINGS_EMAIL_ALIASES_DESCRIPTION" desc="The description for the Email Aliases page"> | ||
Create unique, random addresses that forward to your Brave account email and can be deleted at any time. Keep your actual email address from being disclosed or used by advertisers. | ||
</message> | ||
<message name="IDS_SETTINGS_EMAIL_ALIASES_LEARN_MORE" desc="The label for the learn more link"> | ||
Learn more | ||
</message> | ||
<message name="IDS_SETTINGS_EMAIL_ALIASES_SIGN_OUT" desc="The label for the sign out link"> | ||
Sign out | ||
</message> | ||
<message name="IDS_SETTINGS_EMAIL_ALIASES_SIGN_OUT_TITLE" desc="The title for the sign out link"> | ||
Sign out of Email Aliases | ||
</message> | ||
<message name="IDS_SETTINGS_EMAIL_ALIASES_CONNECTING_TO_BRAVE_ACCOUNT" desc="The label for the connecting to Brave Account"> | ||
Connecting to Brave Account... | ||
</message> | ||
<message name="IDS_SETTINGS_EMAIL_ALIASES_BRAVE_ACCOUNT" desc="The label for the Brave Account"> | ||
Brave Account | ||
</message> | ||
<message name="IDS_SETTINGS_EMAIL_ALIASES_COPIED_TO_CLIPBOARD" desc="The label for the copied to clipboard"> | ||
Copied to clipboard | ||
</message> | ||
<message name="IDS_SETTINGS_EMAIL_ALIASES_CLICK_TO_COPY_ALIAS" desc="The label for the click to copy alias"> | ||
Click to copy alias | ||
</message> | ||
<message name="IDS_SETTINGS_EMAIL_ALIASES_USED_BY" desc="The label for the used by"> | ||
Used by <ph name="DOMAINS">$1<ex>example.com, example.org</ex></ph> | ||
</message> | ||
<message name="IDS_SETTINGS_EMAIL_ALIASES_EDIT" desc="The label for the edit link"> | ||
Edit | ||
</message> | ||
<message name="IDS_SETTINGS_EMAIL_ALIASES_DELETE" desc="The label for the delete link"> | ||
Delete | ||
</message> | ||
<message name="IDS_SETTINGS_EMAIL_ALIASES_CREATE_DESCRIPTION" desc="The description for the create email alias"> | ||
Create up to 5 free email aliases to protect your real email address. | ||
</message> | ||
<message name="IDS_SETTINGS_EMAIL_ALIASES_LIST_TITLE" desc="The title for the email alias list"> | ||
Your email aliases | ||
</message> | ||
<message name="IDS_SETTINGS_EMAIL_ALIASES_CREATE_ALIAS_TITLE" desc="The title for the create alias"> | ||
Create a new alias email | ||
</message> | ||
<message name="IDS_SETTINGS_EMAIL_ALIASES_CREATE_ALIAS_LABEL" desc="The label for the create alias"> | ||
New alias | ||
</message> | ||
<message name="IDS_SETTINGS_EMAIL_ALIASES_REFRESH_BUTTON_TITLE" desc="The title for the refresh button"> | ||
Suggest another email alias | ||
</message> | ||
<message name="IDS_SETTINGS_EMAIL_ALIASES_NOTE_LABEL" desc="The label for the note"> | ||
Note | ||
</message> | ||
<message name="IDS_SETTINGS_EMAIL_ALIASES_EDIT_NOTE_PLACEHOLDER" desc="The placeholder for the edit note"> | ||
Enter a note for your address (optional) | ||
</message> | ||
<message name="IDS_SETTINGS_EMAIL_ALIASES_CANCEL_BUTTON" desc="The label for the cancel button"> | ||
Cancel | ||
</message> | ||
<message name="IDS_SETTINGS_EMAIL_ALIASES_ALIAS_LABEL" desc="The label for the alias"> | ||
Email alias | ||
</message> | ||
<message name="IDS_SETTINGS_EMAIL_ALIASES_EMAILS_WILL_BE_FORWARDED_TO" desc="The label explaining where emails will be forwarded"> | ||
Emails will be forwarded to <ph name="MAIN_EMAIL">$1<ex>[email protected]</ex></ph> | ||
</message> | ||
<message name="IDS_SETTINGS_EMAIL_ALIASES_EDIT_ALIAS_TITLE" desc="The title for the edit alias"> | ||
Edit email alias | ||
</message> | ||
<message name="IDS_SETTINGS_EMAIL_ALIASES_CREATE_ALIAS_BUTTON" desc="The label for the create alias button"> | ||
Create | ||
</message> | ||
<message name="IDS_SETTINGS_EMAIL_ALIASES_SAVE_ALIAS_BUTTON" desc="The label for the save alias button"> | ||
Save | ||
</message> | ||
<message name="IDS_SETTINGS_EMAIL_ALIASES_SIGN_IN_OR_CREATE_ACCOUNT" desc="The label for the sign in or create account"> | ||
To get started, sign in or create a Brave account | ||
</message> | ||
<message name="IDS_SETTINGS_EMAIL_ALIASES_ENTER_EMAIL_TO_GET_LOGIN_LINK" desc="The label for the enter email to get login link"> | ||
Enter your email address to get a secure login link sent to your email. Clicking this link will either create or access a Brave Account and let you use the free Email Aliases service. | ||
</message> | ||
<message name="IDS_SETTINGS_EMAIL_ALIASES_GET_LOGIN_LINK_BUTTON" desc="The label for the get login link button"> | ||
Get login link | ||
</message> | ||
<message name="IDS_SETTINGS_EMAIL_ALIASES_EMAIL_ADDRESS_PLACEHOLDER" desc="The placeholder for the email address"> | ||
Email address | ||
</message> | ||
<message name="IDS_SETTINGS_EMAIL_ALIASES_LOGIN_EMAIL_ON_THE_WAY" desc="The label for the login email on the way"> | ||
A login email is on the way to <ph name="MAIN_EMAIL">$1<ex>[email protected]</ex></ph> | ||
</message> | ||
<message name="IDS_SETTINGS_EMAIL_ALIASES_CLICK_ON_SECURE_LOGIN" desc="The label for the click on secure login"> | ||
Click on the secure login link in the email to access your account. | ||
</message> | ||
<message name="IDS_SETTINGS_EMAIL_ALIASES_DONT_SEE_EMAIL" desc="The label for the don't see email"> | ||
Don't see the email? Check your spam folder or | ||
</message> | ||
<message name="IDS_SETTINGS_EMAIL_ALIASES_TRY_AGAIN" desc="The label for the try again"> | ||
try again. | ||
</message> | ||
|
||
<!-- Settings / New tab page --> | ||
<message name="IDS_SETTINGS_NEW_TAB" desc="The text label for the New Tab settings page"> | ||
New Tab Page | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
# Copyright (c) 2025 The Brave Authors. All rights reserved. | ||
# This Source Code Form is subject to the terms of the Mozilla Public | ||
# License, v. 2.0. If a copy of the MPL was not distributed with this file, | ||
# You can obtain one at https://mozilla.org/MPL/2.0/. | ||
|
||
import("//brave/components/common/typescript.gni") | ||
|
||
transpile_web_ui("email_aliases_ui") { | ||
entry_points = [ [ | ||
"email_aliases", | ||
rebase_path("email_aliases.tsx"), | ||
] ] | ||
|
||
resource_name = "email_aliases" | ||
} | ||
|
||
pack_web_resources("generated_resources") { | ||
resource_name = "email_aliases" | ||
output_dir = | ||
"$root_gen_dir/brave/browser/resources/settings/email_aliases_page" | ||
deps = [ ":email_aliases_ui" ] | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the use of these prefs here for? I'm curious if you think it would be useful to integrity protect them to prevent filesystem tampering here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at what's set in here, yeah let's integrity protect them: https://github.com/brave/brave-core/pull/27127/files#diff-398d0bffbf3c145bfd429720571b80c331b23abf384570fc0403a493bae06a9aR19-R23
The way to do this is by using a "tracked preference" - https://source.chromium.org/chromium/chromium/src/+/main:services/preferences/tracked/