Email aliases implementation #27127

arthuredelstein · 2025-01-06T14:05:27Z

Resolves brave/brave-browser#43115

Submitter Checklist:

I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
There is a ticket for my issue
Used Github auto-closing keywords in the PR description above
Wrote a good PR/commit description
Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
Checked the PR locally:
- npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
- npm run presubmit wiki, npm run gn_check, npm run tslint
Ran git rebase master (if needed)

Reviewer Checklist:

A security review is not needed, or a link to one is included in the PR description
New files have MPL-2.0 license header
Adequate test coverage exists to prevent regressions
Major classes, functions and non-trivial code blocks are well-commented
Changes in component dependencies are properly reflected in gn
Code follows the style guide
Test plan is specified in PR before merging

After-merge Checklist:

The associated issue milestone is set to the smallest version that the
changes has landed on
All relevant documentation has been updated, for instance:

Test Plan:

github-actions · 2025-01-07T00:33:51Z

The following commits were not verified:
19a90a3 (unsigned)
ce6ca42 (unsigned)
0fb4706 (unsigned)

arthuredelstein · 2025-01-07T01:40:50Z

(Not we are using a temporary Brave API Key; we will use the real one programmatically once the backend is ready to use it.)

github-actions · 2025-01-08T03:14:30Z

[puLL-Merge] - brave/brave-core@27127

Description

This PR introduces a new Email Aliases feature to the Brave browser. It adds functionality for users to create, manage, and use email aliases to protect their primary email address. The feature includes a new settings page, a bubble UI for quick alias creation, and integration with Brave's existing systems.

Possible Issues

The PR introduces new network requests to external services, which could potentially impact performance or privacy if not handled carefully.
The implementation adds new preferences and storage mechanisms, which may require migration strategies for existing users.

Security Hotspots

The PR includes API calls to external services (accounts.bsg.bravesoftware.com and aliases.bsg.bravesoftware.com) which handle sensitive user data. Ensure all communications are properly encrypted and authenticated.
The new feature stores authentication tokens and email aliases locally. Verify that this sensitive information is stored securely and not accessible to malicious extensions or scripts.
The implementation allows for the creation and management of email aliases, which could be abused if not properly rate-limited or protected against automated creation.

Changes

Changes

app/brave_command_ids.h:
- Added new command IDs for showing email aliases and creating new aliases.
app/brave_generated_resources.grd:
- Added new string resources for the Email Aliases feature.
app/brave_settings_strings.grdp:
- Added numerous new string resources for the Email Aliases settings page.
browser/brave_browser_features.cc and .h:
- Added a new feature flag kBraveEmailAliases for the Email Aliases feature.
browser/brave_local_state_prefs.cc and browser/brave_profile_prefs.cc:
- Added registration for new Email Aliases preferences.
browser/resources/settings/:
- Added new files for the Email Aliases settings page implementation.
browser/ui/:
- Added new files for the Email Aliases bubble view implementation.
- Modified existing files to integrate the new feature into the browser UI.
browser/ui/webui/:
- Added new handlers and UI implementations for the Email Aliases feature.
chromium_src/:
- Modified various files to integrate the new feature into existing Chrome structures.
components/:
- Added new components for Email Aliases, including preference handling and resources.
ui/webui/resources/:
- Added new icon resources for the Email Aliases feature.

sequenceDiagram
    User->>BraveUI: Clicks "Email Aliases" in settings
    BraveUI->>EmailAliasesHandler: Load Email Aliases page
    EmailAliasesHandler->>MappingService: Get account email
    MappingService->>EmailAliasesHandler: Return account email
    EmailAliasesHandler->>BraveUI: Display Email Aliases page
    User->>BraveUI: Creates new alias
    BraveUI->>EmailAliasesHandler: Create new alias request
    EmailAliasesHandler->>MappingService: Generate new alias
    MappingService->>ExternalService: API call to create alias
    ExternalService->>MappingService: Confirm alias creation
    MappingService->>EmailAliasesHandler: Return new alias
    EmailAliasesHandler->>BraveUI: Update UI with new alias
    BraveUI->>User: Display confirmation

kdenhartog · 2025-01-09T06:58:35Z

browser/brave_profile_prefs.cc

@@ -493,6 +494,8 @@ void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry) {
                                base::Value(false));

  webcompat_reporter::prefs::RegisterProfilePrefs(registry);
+
+  email_aliases::RegisterProfilePrefs(registry);


what's the use of these prefs here for? I'm curious if you think it would be useful to integrity protect them to prevent filesystem tampering here

Looking at what's set in here, yeah let's integrity protect them: https://github.com/brave/brave-core/pull/27127/files#diff-398d0bffbf3c145bfd429720571b80c331b23abf384570fc0403a493bae06a9aR19-R23

The way to do this is by using a "tracked preference" - https://source.chromium.org/chromium/chromium/src/+/main:services/preferences/tracked/

kdenhartog · 2025-01-09T07:02:32Z

browser/ui/toolbar/brave_app_menu_model.cc

+  ui::SimpleMenuModel* autofill_menu_model =
+      static_cast<ui::SimpleMenuModel*>(GetSubmenuModelAt(
+          GetIndexOfCommandId(IDC_PASSWORDS_AND_AUTOFILL_MENU).value()));
+  DCHECK(autofill_menu_model);


is it an issue if this var doesn't get set? Thinking CHECK or error handling with a nil return might be better here if so instead of DCHECK which I believe gets optimized out at build time unless it's a debug build

iefremov · 2025-01-09T19:17:04Z

@arthuredelstein is this one ready for review? Can you link a spec please?

Email aliases implementation

19a90a3

arthuredelstein requested review from a team and bridiver as code owners January 6, 2025 14:05

github-actions bot assigned arthuredelstein Jan 6, 2025

github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) puLL-Merge needs-security-review labels Jan 6, 2025

github-actions bot assigned kdenhartog and thypon Jan 6, 2025

arthuredelstein added 2 commits January 6, 2025 08:51

npm run format

ce6ca42

tidy up

0fb4706

arthuredelstein added 2 commits January 6, 2025 17:00

restrict to android for now

068f12d

make strings available in bubble

86d02e1

arthuredelstein added 4 commits January 7, 2025 10:18

presubmit fix

aace919

not on android right now

adb23a1

presubmit fix

860015a

fix curly brave position

809b021

kdenhartog reviewed Jan 9, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Email aliases implementation #27127

Email aliases implementation #27127

arthuredelstein commented Jan 6, 2025

github-actions bot commented Jan 7, 2025

arthuredelstein commented Jan 7, 2025

github-actions bot commented Jan 8, 2025

Changes

kdenhartog Jan 9, 2025

kdenhartog Jan 9, 2025

kdenhartog Jan 9, 2025

iefremov commented Jan 9, 2025

Email aliases implementation #27127

Are you sure you want to change the base?

Email aliases implementation #27127

Conversation

arthuredelstein commented Jan 6, 2025

Submitter Checklist:

Reviewer Checklist:

After-merge Checklist:

Test Plan:

github-actions bot commented Jan 7, 2025

arthuredelstein commented Jan 7, 2025

github-actions bot commented Jan 8, 2025

Description

Possible Issues

Security Hotspots

Changes

kdenhartog Jan 9, 2025

Choose a reason for hiding this comment

kdenhartog Jan 9, 2025

Choose a reason for hiding this comment

kdenhartog Jan 9, 2025

Choose a reason for hiding this comment

iefremov commented Jan 9, 2025