Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CMake minimum version #391

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Update CMake minimum version #391

merged 2 commits into from
Oct 31, 2024

Conversation

varunagrawal
Copy link
Collaborator

CMake is throwing the warning:

CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.5 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

This PR updates all the CMake files to have the minimum version as 3.5 to fix any potential deprecations as well as maintain the largest generality.

@varunagrawal varunagrawal added the cmake Related to the CMake build system label Oct 1, 2024
@varunagrawal varunagrawal self-assigned this Oct 1, 2024
@varunagrawal
Copy link
Collaborator Author

Merging

@varunagrawal varunagrawal merged commit 138c355 into master Oct 31, 2024
12 checks passed
@varunagrawal varunagrawal deleted the cmake-update branch October 31, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmake Related to the CMake build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant