Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings in python tests #384

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Fix warnings in python tests #384

merged 2 commits into from
Oct 5, 2023

Conversation

varunagrawal
Copy link
Collaborator

Also ran formatting on the test files.

@varunagrawal varunagrawal added the quick review Quick and easy PR to review label Oct 4, 2023
@varunagrawal varunagrawal self-assigned this Oct 4, 2023
yetongumich
yetongumich approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@yetongumich yetongumich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe rerun the Linux checks?

@varunagrawal varunagrawal merged commit 96305ff into master Oct 5, 2023
12 checks passed
@varunagrawal varunagrawal deleted the fixes branch October 5, 2023 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yetongumich yetongumich yetongumich approved these changes

@gchenfc gchenfc Awaiting requested review from gchenfc

Assignees

@varunagrawal varunagrawal

Labels
quick review Quick and easy PR to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@varunagrawal @yetongumich