Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TBB linking #381

Merged
merged 3 commits into from
Sep 19, 2023
Merged

Fix TBB linking #381

merged 3 commits into from
Sep 19, 2023

Conversation

varunagrawal
Copy link
Collaborator

@varunagrawal varunagrawal commented Sep 18, 2023 •
edited
Loading

Update the CMake files to allow for correct linking of TBB, which is currently failing in the CI.

The main change is to delete the FindTBB.cmake file which allows CMake to use the FindTBB version provided by TBB instead.

@varunagrawal varunagrawal added the cmake Related to the CMake build system label Sep 18, 2023
@varunagrawal varunagrawal self-assigned this Sep 18, 2023
achintyamohan
achintyamohan approved these changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@achintyamohan achintyamohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@varunagrawal varunagrawal merged commit e7cda0e into master Sep 19, 2023
12 checks passed
@varunagrawal varunagrawal deleted the fix-tbb-cmake branch September 19, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achintyamohan achintyamohan achintyamohan approved these changes

@ProfFan ProfFan Awaiting requested review from ProfFan

Assignees

@varunagrawal varunagrawal

Labels
cmake Related to the CMake build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@varunagrawal @achintyamohan