-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README and example cmake project #325
Conversation
I think |
I am not sure I understand the issue here. We can build everything within the |
I think I was thinking And I guess the But I think more I was just confused why there were both scripts and examples and deduced from the README that this was the intention, so that's why I updated the cmake files to match the README intention. |
Yeah the scripts directory should probably be merged into the examples directory. Examples are meant to be simple How-Do-I code files. The scope of this PR should change to represent that. |
The examples to me are more complex than scripts and thus need more files involved. A lot of the examples have the main C++ files along with python files for data generation or visualization. None of those projects really show how to integrate GTD, and the fact that we provide the relevant CMake files makes integration pretty straightforward. Moreover, I think being able to run
I don't quite see the reason for this. This is why we have a flag, so users can just turn that flag on when they need the examples built. Having examples within the repo makes more sense since it shows directly how to use certain features. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated the project to compile and run, updated the README, and I believe this now looks great. Let's land it.
Previously the cmake projects in
examples
would not compile naively using the instructions in the README. Specifically, the projects in theexamples
folder cannot be built as standalone cmake projects, they must instead be compiled "under" gtdynamics.i.e. from GTDynamics/CMakeLists.txt,
add_subdirectory(examples)
thenmake example_forward_dynamics.run
works. However, doing something likedoes not work.
This PR clarifies the README instructions, and also creates an example cmake project that does work standalone.
Note we have a little bit of ugliness with sdformat. I'll work on making a .cmake file so we can use
find_package(gtdynamics)
.Also note: I'm not sure what the original intention of the
examples
folder was and how it differs fromscripts
- perhaps these were supposed to be standalone all along but just at some point they stopped working. Not sure.