Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Staging release #718

Merged
merged 27 commits into from
Aug 29, 2024
Merged

Staging release #718

merged 27 commits into from
Aug 29, 2024

Conversation

DaniBitZesty
Copy link
Contributor

📝 A short description of the changes

🔗 Link to the relevant story (or stories)

:shipit: Deployment implications

✅ Checklist

  • Features that cannot go live are behind a feature flag/env var or specify deploy date and open PR as draft
  • I have checked that commit messages make sense and explain the reasoning for each change
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have squashed any unnecessary or part-finished commits

🖼️ Screenshots (if appropriate - no PII/Prod data):

Lubosky and others added 27 commits August 21, 2024 16:53
@Lubosky
Enable pgcrypto PSQL extension
23a5aaa
@Lubosky
Add ProtectedFile model w/ migrations
29f2896
@Lubosky
Add NominationStatsSearch service to get grouped data for report
3c753c2
@Lubosky
Views & policies for nomination statistics
d7b5a60
@Lubosky
Add mailer to send requested CSV file
316aa5c
@TheDancingClown
Merge pull request #711 from bitzesty/nomination-statistics-report
21328d0 
[KAVS0824] Nomination statistics report
@DaniBitZesty
Modify support letter fields so each upload section is a new question
410a097
@DaniBitZesty
Extract question ref code into partial so it only has to be mofified …
e4377e2 
…in one place
@Lubosky
Adjust centering & styling on statistics page
829f49c
@Lubosky
Switch to text layout for email sent to user
ae51742
@DaniBitZesty
Update non-js views with new format for Letters of Support
6ff3e11
@DaniBitZesty
Update how index is written
1c4c572
@Lubosky
Use LEFT JOIN to get also not assigned lieutenancies
00e75c8
@TheDancingClown
Merge pull request #712 from bitzesty/nomination-statistics-report-qa
dff782e 
[KAVS0824] Nomination statistics report [QA]
@TheDancingClown
chore: Update email layout and styling for nomination statistics report
13651e3 
Signed-off-by: Louis Kirkham <[email protected]>
@TheDancingClown
chore: Use existing code for lieutenancy filter
10810b4 
Signed-off-by: Louis Kirkham <[email protected]>
@DaniBitZesty
Non-js destroy action for support letter attachments
b153dcf
@DaniBitZesty
JS remove support letter attachment feature
3c77bbe
@DaniBitZesty
Merge pull request #713 from bitzesty/letters-of-support
fab91b2 
New letters of support question styling
@DaniBitZesty
Fix validation on Letters of Support subquestions
90270c9
@DaniBitZesty
Merge pull request #715 from bitzesty/letters-of-support
ea2df1c 
Fix missing value validation on Letters of Support subquestions
@TheDancingClown
Merge pull request #714 from bitzesty/statistics-table
bb762e9 
Fix: Statistics table QA amendments
@DaniBitZesty
- Remove validation for old letters of support question. This checks …
e30117c 
…if 2 upload blocks have been filled in and adds an overarching error, we now use individual errors beside each input.

- Hide file upload input after successful upload.
- Fix js & non-js validation for support letter attachments.
@macool
Merge pull request #716 from bitzesty/letters-of-support
a263acf
@DaniBitZesty
- Show status of attachment when first uploaded.
9bb0e70 
- Correct file name styling to govuk-body.
- Update first name label on support letters form.
@DaniBitZesty
Remove random square bracket in icon link - causing deployment errors
f06a4a6
@DaniBitZesty
Merge pull request #717 from bitzesty/letters-of-support
9859107 
Letters of support - form UI tweaks
@DaniBitZesty DaniBitZesty merged commit 857d461 into staging Aug 29, 2024
7 of 8 checks passed
@TheDancingClown TheDancingClown mentioned this pull request Aug 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DaniBitZesty @Lubosky @TheDancingClown @macool