-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Production < Staging #722
Merged
Merged
Production < Staging #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Letter of support - upload form
Build support letters if none are present in non-JS version
Signed-off-by: Louis Kirkham <[email protected]> This PR disables the warning for the CK editor warning. It is a temporary fix to hide the warning from users while we apply a major upgrade to CKeditor. https://app.asana.com/0/1199154381249427/1207754952747949/f
Disables ckeditor version warning
Signed-off-by: Louis Kirkham <[email protected]> Adds PDF context for letters of support question https://app.asana.com/0/1199154381249427/1207863714230613/f
Formatting for support letters pdf section
Staging release
Signed-off-by: Louis Kirkham <[email protected]> https://app.asana.com/0/1199154381249427/1207978380074941/f
Form and eligibility changes
Signed-off-by: Louis Kirkham <[email protected]>
Signed-off-by: Louis Kirkham <[email protected]> chore: Update form hint for nominee name field Signed-off-by: Louis Kirkham <[email protected]>
Copy changes to award form
Signed-off-by: Louis Kirkham <[email protected]>
Signed-off-by: Louis Kirkham <[email protected]>
Applies PDF formatting changes to award form
[KAVS0824] Nomination statistics report
[KAVS0824] Nomination statistics report [QA]
Signed-off-by: Louis Kirkham <[email protected]>
Signed-off-by: Louis Kirkham <[email protected]>
New letters of support question styling
Fix missing value validation on Letters of Support subquestions
Fix: Statistics table QA amendments
…if 2 upload blocks have been filled in and adds an overarching error, we now use individual errors beside each input. - Hide file upload input after successful upload. - Fix js & non-js validation for support letter attachments.
- Correct file name styling to govuk-body. - Update first name label on support letters form.
Letters of support - form UI tweaks
Staging release
Update copy in submission banner and file upload message
Staging < main
matthewford
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 A short description of the changes