Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename DbScripts_future and DbScripts_data_migrations #3192

Merged
merged 5 commits into from
Oct 12, 2023
Merged

Rename DbScripts_future and DbScripts_data_migrations #3192

merged 5 commits into from
Oct 12, 2023

Conversation

mimartin12
Copy link
Contributor

@mimartin12 mimartin12 commented Aug 14, 2023 •
edited
Loading

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [X] Other

Objective

Rename the DbScripts folders to more accurately represent our process defined in bitwarden/contributing-docs#166

Code changes

  • DbScripts_future: Renamed to DbScripts_finalization
  • DbScripts_data_migration: Renamed to DbScripts_transition

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • If making database changes - make sure you also update Entity Framework queries and/or migrations
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@bitwarden-bot
Copy link

bitwarden-bot commented Aug 14, 2023 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – 9494716e-9c92-47d1-91a6-a032fc711d30

No New Or Fixed Issues Found

@mimartin12 mimartin12 marked this pull request as ready for review August 15, 2023 20:45
@mimartin12 mimartin12 mentioned this pull request Aug 15, 2023
Merged
@mimartin12 mimartin12 requested review from a team August 17, 2023 19:52
@michalchecinski michalchecinski mentioned this pull request Sep 27, 2023
Merged
@mimartin12 mimartin12 merged commit f228dcd into master Oct 12, 2023
42 checks passed
@mimartin12 mimartin12 deleted the DEVOPS-1520-rename-dbo-future-and-db-scripts-data-migrations branch October 12, 2023 18:42
@joseph-flinn joseph-flinn mentioned this pull request Oct 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shane-melton shane-melton shane-melton approved these changes

@michalchecinski michalchecinski michalchecinski left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mimartin12 @bitwarden-bot @shane-melton @michalchecinski