Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename DbScripts_future to DbScripts_finalization #177

Merged

Conversation

mimartin12
Copy link
Contributor

@mimartin12 mimartin12 commented Aug 14, 2023

Objective

@bitwarden-bot
Copy link

bitwarden-bot commented Aug 14, 2023

Logo
Checkmarx One – Scan Summary & Details5169183a-c454-4f20-9858-3f6b555d17cf

No New Or Fixed Issues Found

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 14, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e24d8a2
Status: ✅  Deploy successful!
Preview URL: https://f6e3184b.contributing-docs.pages.dev
Branch Preview URL: https://devops-1520-rename-dbo-futur.contributing-docs.pages.dev

View logs

@mimartin12 mimartin12 marked this pull request as ready for review August 15, 2023 20:46
@mimartin12 mimartin12 requested a review from a team as a code owner August 15, 2023 20:46
Copy link
Member

@differsthecat differsthecat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what the issue is as your changes look good, but the lint job is mad about something in docs/contributing/database-migrations/index.md.

@withinfocus
Copy link
Contributor

This shouldn't merge until #166 completes.

Copy link
Member

@differsthecat differsthecat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mimartin12 , This looks good now. Per @withinfocus 's comment, I'll approve once #166 is merged!

@mimartin12 mimartin12 merged commit 0b10134 into master Oct 12, 2023
3 checks passed
@mimartin12 mimartin12 deleted the DEVOPS-1520-rename-dbo-future-and-db-scripts-data-migrations branch October 12, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants