Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-7565] fix filter icon alignment #8790

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

SamFrank234
Copy link
Contributor

@SamFrank234 SamFrank234 commented Apr 17, 2024

update styles so that folders and subfolders are correctly aligned in vault filters on web and desktop

Type of change

- [X] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Fixes #8553

Small styling fix to align icons in vault filters when subfolders are present. Desktop and web.

Code changes

Added a margin-right style attribute to the "toggle-button" class (folders with subfolders) to match the layout of
the "filter-button" class (folders without subfolders).

Screenshots

Screen Shot 2024-04-17 at 1 29 39 PM

update styles so that folders and subfolders are correctly aligned
in vault filters on web and desktop
@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-7565

@bitwarden-bot bitwarden-bot changed the title fix filter icon alignment [PM-7565] fix filter icon alignment Apr 17, 2024
@djsmith85 djsmith85 requested a review from a team April 18, 2024 09:51
@michnovka
Copy link

Any update on this?

@djsmith85 djsmith85 requested review from a team and shane-melton October 9, 2024 08:39
@shane-melton shane-melton requested a review from Jingo88 October 9, 2024 14:55
@Jingo88 Jingo88 added the needs-qa Marks a PR as requiring QA approval label Oct 14, 2024
@Jingo88 Jingo88 removed the needs-qa Marks a PR as requiring QA approval label Oct 23, 2024
@Jingo88 Jingo88 merged commit 7c79487 into bitwarden:main Oct 23, 2024
58 of 65 checks passed
@Jingo88
Copy link
Contributor

Jingo88 commented Oct 23, 2024

PR has passed QA. Approved and merged. Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Folder names are aligned, depending if subfolders are present or not
5 participants