Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Community PR [PM-7565] fix filter icon alignment #11547

Closed
wants to merge 1 commit into from
Closed

Community PR [PM-7565] fix filter icon alignment #11547

wants to merge 1 commit into from

Conversation

Jingo88
Copy link
Contributor

@Jingo88 Jingo88 commented Oct 14, 2024 •
edited by jira bot
Loading

🎟️ Tracking

PM-7565

📔 Objective

PR to build artifacts for Community PR

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@SamFrank234
fix filter icon alignment
f681a12 
update styles so that folders and subfolders are correctly aligned
in vault filters on web and desktop
@Jingo88 Jingo88 added hold do not merge, do not approve yet needs-qa Marks a PR as requiring QA approval labels Oct 14, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.16%. Comparing base (e448168) to head (f681a12).
Report is 1745 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11547      +/-   ##
==========================================
+ Coverage   27.35%   33.16%   +5.81%     
==========================================
  Files        2348     2779     +431     
  Lines       68538    86235   +17697     
  Branches    12818    16425    +3607     
==========================================
+ Hits        18748    28604    +9856     
- Misses      48380    55365    +6985     
- Partials     1410     2266     +856

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details – 7976c578-478b-4830-a715-6480b42b9311

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Absolute_Path_Traversal /apps/cli/src/commands/serve.command.ts: 343 Attack Vector
MEDIUM Absolute_Path_Traversal /apps/cli/src/commands/serve.command.ts: 311 Attack Vector
MEDIUM Absolute_Path_Traversal /apps/cli/src/commands/serve.command.ts: 343 Attack Vector
MEDIUM Absolute_Path_Traversal /apps/cli/src/commands/serve.command.ts: 311 Attack Vector
MEDIUM Angular_Improper_Type_Pipe_Usage /apps/web/src/app/billing/organizations/adjust-subscription.component.html: 54 Attack Vector
MEDIUM Angular_Improper_Type_Pipe_Usage /apps/web/src/app/billing/organizations/adjust-subscription.component.html: 18 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/pages/list/autofill-overlay-list.ts: 250 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/pages/list/autofill-overlay-list.ts: 420 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/pages/list/autofill-overlay-list.ts: 464 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/pages/list/autofill-overlay-list.ts: 249 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/pages/list/autofill-overlay-list.ts: 462 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/pages/list/autofill-overlay-list.ts: 405 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/pages/list/autofill-overlay-list.ts: 390 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/background/overlay.background.ts: 94 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/background/overlay.background.ts: 94 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/pages/list/autofill-overlay-list.ts: 409 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/pages/list/autofill-overlay-list.ts: 257 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/background/overlay.background.ts: 152 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/background/overlay.background.ts: 152 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/background/overlay.background.ts: 152 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/background/overlay.background.ts: 152 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/pages/list/autofill-overlay-list.ts: 53 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/pages/list/autofill-overlay-list.ts: 53 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/pages/list/autofill-overlay-list.ts: 53 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/pages/list/autofill-overlay-list.ts: 53 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/pages/list/autofill-overlay-list.ts: 28 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/pages/list/autofill-overlay-list.ts: 28 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/pages/list/autofill-overlay-list.ts: 28 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/pages/list/autofill-overlay-list.ts: 28 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/pages/list/autofill-overlay-list.ts: 419 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/pages/list/autofill-overlay-list.ts: 19 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/pages/list/autofill-overlay-list.ts: 19 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/pages/list/autofill-overlay-list.ts: 19 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/pages/list/autofill-overlay-list.ts: 19 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/pages/list/autofill-overlay-list.ts: 446 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/pages/list/autofill-overlay-list.ts: 446 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/pages/list/autofill-overlay-list.ts: 230 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/background/overlay.background.ts: 189 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/background/overlay.background.ts: 189 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/background/overlay.background.ts: 176 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/background/overlay.background.ts: 176 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/popup/settings/options.component.ts: 106 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/pages/list/autofill-overlay-list.ts: 444 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/pages/list/autofill-overlay-list.ts: 444 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/background/overlay.background.ts: 190 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/background/overlay.background.ts: 190 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/background/overlay.background.ts: 174 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/background/overlay.background.ts: 174 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/pages/list/autofill-overlay-list.ts: 228 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/pages/list/autofill-overlay-list.ts: 228 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/background/overlay.background.ts: 188 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/background/overlay.background.ts: 188 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/background/overlay.background.ts: 184 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/background/overlay.background.ts: 184 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/background/overlay.background.ts: 183 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/background/overlay.background.ts: 183 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/background/overlay.background.ts: 182 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/background/overlay.background.ts: 182 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/popup/settings/autofill.component.ts: 74 Attack Vector
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 406 Attack Vector
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 490 Attack Vector
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 490 Attack Vector
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/bulk-action-dialogs/bulk-delete-dialog/bulk-delete-dialog.component.html: 16 Attack Vector
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/individual-vault/bulk-action-dialogs/bulk-delete-dialog/bulk-delete-dialog.component.html: 8 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/pages/list/autofill-overlay-list.ts: 129 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/pages/list/autofill-overlay-list.ts: 129 Attack Vector
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 60 Attack Vector
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 56 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/fido2/fido2-cipher-row.component.ts: 9 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/vault/popup/components/fido2/fido2-cipher-row.component.ts: 9 Attack Vector
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 524 Attack Vector
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 520 Attack Vector
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 516 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/pages/list/autofill-overlay-list.ts: 422 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/pages/list/autofill-overlay-list.ts: 422 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/pages/list/autofill-overlay-list.ts: 422 Attack Vector
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 399 Attack Vector
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 397 Attack Vector
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 395 Attack Vector
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 394 Attack Vector
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 393 Attack Vector
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 370 Attack Vector
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 361 Attack Vector
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 352 Attack Vector
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 343 Attack Vector
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 334 Attack Vector
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 325 Attack Vector
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 316 Attack Vector
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 307 Attack Vector
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 269 Attack Vector
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 268 Attack Vector
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 258 Attack Vector
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 249 Attack Vector
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 199 Attack Vector
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 27 Attack Vector
MEDIUM Client_Privacy_Violation /apps/desktop/src/vault/app/vault/view.component.html: 475 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/popup/settings/options.component.html: 95 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/pages/list/autofill-overlay-list.ts: 20 Attack Vector
MEDIUM

More results are available on AST platform

@Jingo88
Copy link
Contributor Author

Jingo88 commented Oct 23, 2024

QA Approved. Squashed and merged community PR. Closing this temp PR.

@Jingo88 Jingo88 closed this Oct 23, 2024
@djsmith85 djsmith85 deleted the community/PM-7565/filter-icon-alignment branch October 23, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hold do not merge, do not approve yet needs-qa Marks a PR as requiring QA approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jingo88 @SamFrank234