[PM-15180] - update copy for free trial banner #12151
+25
−25
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -1642,27 +1642,9 @@ | |||||
| "passwordHistory": { | ||||||
| "message": "Password history" | ||||||
| }, | ||||||
| "noPasswordsInList": { | ||||||
| "message": "There are no passwords to list." | ||||||
| }, | ||||||
| "clear": { | ||||||
| "message": "Clear", | ||||||
| "description": "To clear something out. Example: To clear browser history." | ||||||
|
|
@@ -3879,6 +3861,15 @@ | |||||
| } | ||||||
| } | ||||||
| }, | ||||||
| "freeTrialEndPromptV2": { | ||||||
| "message": "Your free trial ends in $COUNT$ days.", | ||||||
| "placeholders": { | ||||||
| "count": { | ||||||
| "content": "$1", | ||||||
| "example": "You must set up 2FA on your user account before you can join this organization." | ||||||
|
There was a problem hiding this comment. i just noticed, this example text is wrong. |
||||||
| } | ||||||
| } | ||||||
| }, | ||||||
| "freeTrialEndPromptAboveTwoDays": { | ||||||
| "message": "$ORGANIZATION$, your free trial ends in $COUNT$ days. To maintain your subscription,", | ||||||
|
There was a problem hiding this comment. Did business requested that There was a problem hiding this comment. @cyprain-okeke Given how different languages break up sentences in different ways and the fact this translation in particular was broken between 2 keys it was decided to make both keys complete sentences in order to allow for proper translation. There was a problem hiding this comment. Please provide a video recording There was a problem hiding this comment. @cyprain-okeke Sorry I'm not sure what you mean. What would you like the recording of? I can provide a screenshot of what new copy looks like if that's what you'd like. There was a problem hiding this comment. run the application and test it, while testing record it and attached it to the pr. There was a problem hiding this comment. @cyprain-okeke Screen recording attached |
||||||
| "placeholders": { | ||||||
|
|
@@ -3892,6 +3883,19 @@ | |||||
| } | ||||||
| } | ||||||
| }, | ||||||
| "freeTrialEndPromptAboveTwoDaysV2": { | ||||||
| "message": "$ORGANIZATION$, your free trial ends in $COUNT$ days.", | ||||||
| "placeholders": { | ||||||
| "count": { | ||||||
|
There was a problem hiding this comment. the example text is wrong for the two placeholders. |
||||||
| "content": "$2", | ||||||
| "example": "organization name" | ||||||
| }, | ||||||
| "organization": { | ||||||
| "content": "$1", | ||||||
| "example": "remaining days" | ||||||
| } | ||||||
| } | ||||||
| }, | ||||||
| "freeTrialEndPromptForOneDay": { | ||||||
| "message": "$ORGANIZATION$, your free trial ends tomorrow. To maintain your subscription,", | ||||||
| "placeholders": { | ||||||
|
|
@@ -3901,9 +3905,21 @@ | |||||
| } | ||||||
| } | ||||||
| }, | ||||||
| "freeTrialEndPromptForOneDayV2": { | ||||||
| "message": "$ORGANIZATION$, your free trial ends tomorrow.", | ||||||
| "placeholders": { | ||||||
| "organization": { | ||||||
| "content": "$1", | ||||||
| "example": "organization name" | ||||||
| } | ||||||
| } | ||||||
| }, | ||||||
| "freeTrialEndPromptForOneDayNoOrgName": { | ||||||
| "message": "Your free trial ends tomorrow. To maintain your subscription," | ||||||
| }, | ||||||
| "freeTrialEndPromptForOneDayNoOrgNameV2": { | ||||||
| "message": "Your free trial ends tomorrow." | ||||||
| }, | ||||||
| "freeTrialEndPromptForLessThanADay": { | ||||||
| "message": "$ORGANIZATION$, your free trial ends today. To maintain your subscription,", | ||||||
| "placeholders": { | ||||||
|
|
@@ -3913,12 +3929,27 @@ | |||||
| } | ||||||
| } | ||||||
| }, | ||||||
| "freeTrialEndPromptForLessThanADayV2": { | ||||||
| "message": "$ORGANIZATION$, your free trial ends today.", | ||||||
| "placeholders": { | ||||||
| "organization": { | ||||||
| "content": "$1", | ||||||
| "example": "organization name" | ||||||
| } | ||||||
| } | ||||||
| }, | ||||||
| "freeTrialEndingSoonWithoutOrgName": { | ||||||
| "message": "Your free trial ends today. To maintain your subscription," | ||||||
| }, | ||||||
| "freeTrialEndingSoonWithoutOrgNameV2": { | ||||||
| "message": "Your free trial ends today." | ||||||
| }, | ||||||
| "routeToPaymentMethodTrigger": { | ||||||
| "message": "add a payment method." | ||||||
| }, | ||||||
| "routeToPaymentMethodTriggerV2": { | ||||||
| "message": "Click here add a payment method." | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| }, | ||||||
| "joinOrganization": { | ||||||
| "message": "Join organization" | ||||||
| }, | ||||||
|
|
@@ -8069,18 +8100,9 @@ | |||||
| "loginInitiated": { | ||||||
| "message": "Login initiated" | ||||||
| }, | ||||||
| "deviceApprovalRequired": { | ||||||
| "message": "Device approval required. Select an approval option below:" | ||||||
| }, | ||||||
| "rememberThisDevice": { | ||||||
| "message": "Remember this device" | ||||||
| }, | ||||||
|
|
@@ -8310,9 +8332,6 @@ | |||||
| "userEmailMissing": { | ||||||
| "message": "User email missing" | ||||||
| }, | ||||||
| "deviceTrusted": { | ||||||
| "message": "Device trusted" | ||||||
| }, | ||||||
|
|
@@ -8408,6 +8427,9 @@ | |||||
| "collectionManagementDesc": { | ||||||
| "message": "Manage the collection behavior for the organization" | ||||||
| }, | ||||||
| "limitCollectionCreationDeletionDesc": { | ||||||
| "message": "Limit collection creation and deletion to owners and admins" | ||||||
| }, | ||||||
| "limitCollectionCreationDesc": { | ||||||
| "message": "Limit collection creation to owners and admins" | ||||||
| }, | ||||||
|
|
||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could not find this in
messages.json