[PM-15180] - update copy for free trial banner #12151
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #12151 +/- ##
=======================================
Coverage 33.47% 33.48%
=======================================
Files 2875 2875
Lines 89834 89834
Branches 17103 17103
=======================================
+ Hits 30073 30080 +7
+ Misses 57385 57378 -7
Partials 2376 2376 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
@jaasen-livefront If you are changing the context/meaning of a message, you'll need to delete the old key+message and any usages and create a new pair.
This is to ensure that any messages that were translated with the old meaning are deleted and the new text is present for the translations
| "placeholders": { | ||
| "count": { | ||
| "content": "$1", | ||
| "example": "You must set up 2FA on your user account before you can join this organization." | ||
| } | ||
| } | ||
| }, | ||
| "freeTrialEndPromptAboveTwoDays": { | ||
| "message": "$ORGANIZATION$, your free trial ends in $COUNT$ days. To maintain your subscription,", |
There was a problem hiding this comment.
Did business requested that To maintain your subscription, be removed?
There was a problem hiding this comment.
@cyprain-okeke Given how different languages break up sentences in different ways and the fact this translation in particular was broken between 2 keys it was decided to make both keys complete sentences in order to allow for proper translation.
There was a problem hiding this comment.
Please provide a video recording
There was a problem hiding this comment.
@cyprain-okeke Sorry I'm not sure what you mean. What would you like the recording of? I can provide a screenshot of what new copy looks like if that's what you'd like.
There was a problem hiding this comment.
run the application and test it, while testing record it and attached it to the pr.
There was a problem hiding this comment.
@cyprain-okeke Screen recording attached
| "freeTrialEndPrompt": { | ||
| "message": "Your free trial ends in $COUNT$ days. To maintain your subscription,", | ||
| "freeTrialEndPromptCount": { | ||
| "message": "Your free trial ends in $COUNT$ days.", | ||
| "placeholders": { | ||
| "count": { | ||
| "content": "$1", | ||
| "example": "You must set up 2FA on your user account before you can join this organization." |
There was a problem hiding this comment.
i just noticed, this example text is wrong.
| @@ -14,7 +14,7 @@ | |||
| class="tw-cursor-pointer" | |||
| rel="noreferrer noopener" | |||
| > | |||
| {{ "routeToPaymentMethodTrigger" | i18n }} | |||
| {{ "routeToPaymentMethodTriggerV2" | i18n }} | |||
There was a problem hiding this comment.
Could not find this in messages.json
| "freeTrialEndPromptAboveTwoDays": { | ||
| "message": "$ORGANIZATION$, your free trial ends in $COUNT$ days. To maintain your subscription,", | ||
| "freeTrialEndPromptMultipleDays": { | ||
| "message": "$ORGANIZATION$, your free trial ends in $COUNT$ days.", | ||
| "placeholders": { | ||
| "count": { |
There was a problem hiding this comment.
the example text is wrong for the two placeholders.
| "routeToPaymentMethodTrigger": { | ||
| "message": "add a payment method." | ||
| "clickHereToAddPaymentMethod": { | ||
| "message": "Click here add a payment method." |
There was a problem hiding this comment.
| "message": "Click here add a payment method." | |
| "message": "Click here to add a payment method." |
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-15180
📔 Objective
This PR updates the translation keys for the different trial banners to all have complete sentences to allow for proper translation.
📸 Screenshots
Uploading Screen Recording 2024-11-25 at 3.43.04 PM.mov…
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes