Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BITAU-218] Revert Changes to Pull to Refresh #202

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

brant-livefront
Copy link
Collaborator

🎟️ Tracking

BITAU-218

📔 Objective

The changes in PR #185 (when merged) left a small line appearing at the top. This PR reverts those changes for now, which fixes the line but returns the problem of a small space potentially appearing at the top on pull to refresh. We are hoping to cut an RC branch for Authenticator and I don't want to ship that with the line in the build, so this PR fixes that immediate issue, which BITAU-218 remaining as a ticket to fix it permanently.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.74%. Comparing base (3c03964) to head (578ec2c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ared/UI/Vault/ItemList/ItemList/ItemListView.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #202      +/-   ##
==========================================
- Coverage   67.79%   67.74%   -0.06%     
==========================================
  Files         214      214              
  Lines        9623     9619       -4     
==========================================
- Hits         6524     6516       -8     
- Misses       3099     3103       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Logo
Checkmarx One – Scan Summary & Details258a2b07-c8a0-4a4a-9a99-d796bcd15467

No New Or Fixed Issues Found

@brant-livefront brant-livefront merged commit b06a6fb into main Dec 2, 2024
9 checks passed
@brant-livefront brant-livefront deleted the brant/revert-pull-to-refresh-change branch December 2, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants