[BITAU-218] Revert Changes to Pull to Refresh (#202)

bitwarden · Dec 2, 2024 · b06a6fb · b06a6fb
1 parent 3c03964
commit b06a6fb
Show file tree

Hide file tree

Showing 32 changed files with 1 addition and 5 deletions.
diff --git a/AuthenticatorShared/UI/Vault/ItemList/ItemList/ItemListView.swift b/AuthenticatorShared/UI/Vault/ItemList/ItemList/ItemListView.swift
@@ -39,8 +39,6 @@ private struct SearchableItemListView: View {
     // MARK: View
 
     var body: some View {
-        PreserveLargeTitleView()
-
         // A ZStack with hidden children is used here so that opening and closing the
         // search interface does not reset the scroll position for the main vault
         // view, as would happen if we used an `if else` block here.
@@ -376,9 +374,7 @@ struct ItemListView: View {
                 await store.perform(.search(store.state.searchText))
             }
             .refreshable {
-                Task {
-                    await store.perform(.refresh)
-                }
+                await store.perform(.refresh)
             }
         }
         .navigationTitle(Localizations.verificationCodes)

diff --git a/...pshots__/ItemListViewTests/test_snapshot_ItemListView_card_download_empty.1.png b/...pshots__/ItemListViewTests/test_snapshot_ItemListView_card_download_empty.1.png
diff --git a/...s__/ItemListViewTests/test_snapshot_ItemListView_card_download_with_items.1.png b/...s__/ItemListViewTests/test_snapshot_ItemListView_card_download_with_items.1.png
diff --git a/..._Snapshots__/ItemListViewTests/test_snapshot_ItemListView_card_sync_empty.1.png b/..._Snapshots__/ItemListViewTests/test_snapshot_ItemListView_card_sync_empty.1.png
diff --git a/...shots__/ItemListViewTests/test_snapshot_ItemListView_card_sync_with_items.1.png b/...shots__/ItemListViewTests/test_snapshot_ItemListView_card_sync_with_items.1.png
diff --git a/...ListViewTests/test_snapshot_ItemListView_previews.0-Search-Results-portrait.png b/...ListViewTests/test_snapshot_ItemListView_previews.0-Search-Results-portrait.png
diff --git a/...tViewTests/test_snapshot_ItemListView_previews.0-Search-Results-portraitAX5.png b/...tViewTests/test_snapshot_ItemListView_previews.0-Search-Results-portraitAX5.png
diff --git a/...ViewTests/test_snapshot_ItemListView_previews.0-Search-Results-portraitDark.png b/...ViewTests/test_snapshot_ItemListView_previews.0-Search-Results-portraitDark.png
diff --git a/...mListViewTests/test_snapshot_ItemListView_previews.1-Search-Result-portrait.png b/...mListViewTests/test_snapshot_ItemListView_previews.1-Search-Result-portrait.png
diff --git a/...stViewTests/test_snapshot_ItemListView_previews.1-Search-Result-portraitAX5.png b/...stViewTests/test_snapshot_ItemListView_previews.1-Search-Result-portraitAX5.png
diff --git a/...tViewTests/test_snapshot_ItemListView_previews.1-Search-Result-portraitDark.png b/...tViewTests/test_snapshot_ItemListView_previews.1-Search-Result-portraitDark.png
diff --git a/...ListViewTests/test_snapshot_ItemListView_previews.3-Search-Results-portrait.png b/...ListViewTests/test_snapshot_ItemListView_previews.3-Search-Results-portrait.png
diff --git a/...tViewTests/test_snapshot_ItemListView_previews.3-Search-Results-portraitAX5.png b/...tViewTests/test_snapshot_ItemListView_previews.3-Search-Results-portraitAX5.png
diff --git a/...ViewTests/test_snapshot_ItemListView_previews.3-Search-Results-portraitDark.png b/...ViewTests/test_snapshot_ItemListView_previews.3-Search-Results-portraitDark.png
diff --git a/...ots__/ItemListViewTests/test_snapshot_ItemListView_previews.Digits-portrait.png b/...ots__/ItemListViewTests/test_snapshot_ItemListView_previews.Digits-portrait.png
diff --git a/...__/ItemListViewTests/test_snapshot_ItemListView_previews.Digits-portraitAX5.png b/...__/ItemListViewTests/test_snapshot_ItemListView_previews.Digits-portraitAX5.png
diff --git a/..._/ItemListViewTests/test_snapshot_ItemListView_previews.Digits-portraitDark.png b/..._/ItemListViewTests/test_snapshot_ItemListView_previews.Digits-portraitDark.png
diff --git a/...hots__/ItemListViewTests/test_snapshot_ItemListView_previews.Empty-portrait.png b/...hots__/ItemListViewTests/test_snapshot_ItemListView_previews.Empty-portrait.png
diff --git a/...s__/ItemListViewTests/test_snapshot_ItemListView_previews.Empty-portraitAX5.png b/...s__/ItemListViewTests/test_snapshot_ItemListView_previews.Empty-portraitAX5.png
diff --git a/...__/ItemListViewTests/test_snapshot_ItemListView_previews.Empty-portraitDark.png b/...__/ItemListViewTests/test_snapshot_ItemListView_previews.Empty-portraitDark.png
diff --git a/...tViewTests/test_snapshot_ItemListView_previews.Items-with-Favorite-portrait.png b/...tViewTests/test_snapshot_ItemListView_previews.Items-with-Favorite-portrait.png
diff --git a/...ewTests/test_snapshot_ItemListView_previews.Items-with-Favorite-portraitAX5.png b/...ewTests/test_snapshot_ItemListView_previews.Items-with-Favorite-portraitAX5.png
diff --git a/...wTests/test_snapshot_ItemListView_previews.Items-with-Favorite-portraitDark.png b/...wTests/test_snapshot_ItemListView_previews.Items-with-Favorite-portraitDark.png
diff --git a/...ewTests/test_snapshot_ItemListView_previews.Items-without-Favorite-portrait.png b/...ewTests/test_snapshot_ItemListView_previews.Items-without-Favorite-portrait.png
diff --git a/...ests/test_snapshot_ItemListView_previews.Items-without-Favorite-portraitAX5.png b/...ests/test_snapshot_ItemListView_previews.Items-without-Favorite-portraitAX5.png
diff --git a/...sts/test_snapshot_ItemListView_previews.Items-without-Favorite-portraitDark.png b/...sts/test_snapshot_ItemListView_previews.Items-without-Favorite-portraitDark.png
diff --git a/...ts__/ItemListViewTests/test_snapshot_ItemListView_previews.Loading-portrait.png b/...ts__/ItemListViewTests/test_snapshot_ItemListView_previews.Loading-portrait.png
diff --git a/..._/ItemListViewTests/test_snapshot_ItemListView_previews.Loading-portraitAX5.png b/..._/ItemListViewTests/test_snapshot_ItemListView_previews.Loading-portraitAX5.png
diff --git a/.../ItemListViewTests/test_snapshot_ItemListView_previews.Loading-portraitDark.png b/.../ItemListViewTests/test_snapshot_ItemListView_previews.Loading-portraitDark.png
diff --git a/...__/ItemListViewTests/test_snapshot_ItemListView_previews.SyncError-portrait.png b/...__/ItemListViewTests/test_snapshot_ItemListView_previews.SyncError-portrait.png
diff --git a/...ItemListViewTests/test_snapshot_ItemListView_previews.SyncError-portraitAX5.png b/...ItemListViewTests/test_snapshot_ItemListView_previews.SyncError-portraitAX5.png
diff --git a/...temListViewTests/test_snapshot_ItemListView_previews.SyncError-portraitDark.png b/...temListViewTests/test_snapshot_ItemListView_previews.SyncError-portraitDark.png