Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-14995 Hide TOTP for non premium org items even if individual user has premium account #4390

Merged
merged 2 commits into from
Dec 2, 2024
+317 −54

orEmpty() + formtatting

129fa27
Select commit
Loading
Failed to load commit list.
Merged

PM-14995 Hide TOTP for non premium org items even if individual user has premium account #4390

orEmpty() + formtatting
129fa27
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 2, 2024 in 0s

89.00% (-0.02%) compared to 05aa52b

View this Pull Request on Codecov

89.00% (-0.02%) compared to 05aa52b

Details

Codecov Report

Attention: Patch coverage is 71.21212% with 19 lines in your changes missing coverage. Please review.

Project coverage is 89.00%. Comparing base (05aa52b) to head (129fa27).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...warden/ui/vault/feature/item/VaultItemViewModel.kt 45.45% 1 Missing and 5 partials ⚠️
...ui/vault/feature/vault/util/VaultDataExtensions.kt 70.58% 2 Missing and 3 partials ⚠️
...n/data/autofill/manager/AutofillTotpManagerImpl.kt 50.00% 0 Missing and 4 partials ⚠️
...ture/verificationcode/VerificationCodeViewModel.kt 50.00% 0 Missing and 2 partials ⚠️
...rm/feature/search/util/SearchTypeDataExtensions.kt 66.66% 0 Missing and 1 partial ⚠️
...itemlisting/util/VaultItemListingDataExtensions.kt 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4390      +/-   ##
==========================================
- Coverage   89.01%   89.00%   -0.02%     
==========================================
  Files         451      451              
  Lines       39123    39172      +49     
  Branches     5532     5550      +18     
==========================================
+ Hits        34827    34864      +37     
- Misses       2368     2370       +2     
- Partials     1928     1938      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov