PM-14995 Hide TOTP for non premium org items even if individual user has premium account

[dseverns-livefront]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-14995

📔 Objective

• A user with premium should not be able to use TOTP codes on items held by a non premium organization.

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
  issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[github-actions]

Checkmarx One – Scan Summary & Details – c23c3bd5-6bd8-43c0-b145-e9bba406d01b

New Issues

Severity	Issue	Source File / Package	Checkmarx Insight
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 346	Attack Vector
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 346	Attack Vector
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/createaccount/CreateAccountViewModel.kt: 321	Attack Vector
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/createaccount/CreateAccountViewModel.kt: 321	Attack Vector
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemViewModel.kt: 876	Attack Vector

Fixed Issues

Severity	Issue	Source File / Package
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/data/autofill/manager/AutofillTotpManagerImpl.kt: 29
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 341
	Privacy_Violation	/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt: 341
	Unpinned Actions Full Length Commit SHA	/crowdin-pull.yml: 26

[codecov]

Codecov Report

Attention: Patch coverage is 71.21212% with 19 lines in your changes missing coverage. Please review.

Project coverage is 89.00%. Comparing base (05aa52b) to head (129fa27).
Report is 10 commits behind head on main.

Files with missing lines	Patch %	Lines
...warden/ui/vault/feature/item/VaultItemViewModel.kt	45.45%	1 Missing and 5 partials ⚠️
...ui/vault/feature/vault/util/VaultDataExtensions.kt	70.58%	2 Missing and 3 partials ⚠️
...n/data/autofill/manager/AutofillTotpManagerImpl.kt	50.00%	0 Missing and 4 partials ⚠️
...ture/verificationcode/VerificationCodeViewModel.kt	50.00%	0 Missing and 2 partials ⚠️
...rm/feature/search/util/SearchTypeDataExtensions.kt	66.66%	0 Missing and 1 partial ⚠️
...itemlisting/util/VaultItemListingDataExtensions.kt	66.66%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4390      +/-   ##
==========================================
- Coverage   89.01%   89.00%   -0.02%     
==========================================
  Files         451      451              
  Lines       39123    39172      +49     
  Branches     5532     5550      +18     
==========================================
+ Hits        34827    34864      +37     
- Misses       2368     2370       +2     
- Partials     1928     1938      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[david-livefront]

Can we just do orEmpty()

[david-livefront]

Formatting here

[david-livefront]

Can we do more orEmpty()s

[bsteimel]

This feature is in direct violation to the outline of your user agreements and feature list.

"Storage of keys is available to all accounts, however TOTP code generation requires Premium or membership to a paid organization (Families, Teams, or Enterprise)." https://bitwarden.com/help/integrated-authenticator/

OR not AND

[JaggedJax]

@dseverns-livefront @SaintPatrck this PR goes against all of the copy on the Bitwarden website[1][2] and removes access to TOTP codes for paid customers with ZERO notice. This needs to be reverted.

[1]https://bitwarden.com/help/about-organizations/#comparing-organizations-with-premium
[2]https://bitwarden.com/help/integrated-authenticator/