build: use Ninja for workspace builds#1021
Draft
jaagut wants to merge 2 commits into
Draft
Conversation
Member
|
We intentionally opted out of ninja as there where some bugs and due to a controversial opinion of its creator all logs are written to stderr which makes the build really verbose if we want to see build errors at all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switch the default and robot CMake generator from Unix Makefiles to Ninja.
Proposed changes
Impact
Ninja reduces build orchestration overhead and can improve parallel scheduling without changing the compiler or generated runtime code. Existing Makefile build directories must be cleaned once before using this branch.
Stack
This PR is based on
agent/build-benchmark-baselineso its CI timings can be compared with the baseline PR.Validation
pixi.tomlwith Python's TOML parser.bitbots_head_moversuccessfully with the Ninja generator.git diff --check