fix: broken Yarn PnP binary finder strategy

.vscode/launch.json

@@ -83,6 +83,20 @@
 			"outFiles": ["${workspaceFolder}/out/**/*.js"],
 			"preLaunchTask": "npm: dev",
 			"sourceMapRenames": true
+		},
+		{
+			"name": "🧩 Debug Extension (yarn pnp)",
+			"type": "extensionHost",
+			"request": "launch",
+			"args": [
+				"--disable-extensions",
+				"--extensionDevelopmentKind=node",
+				"--extensionDevelopmentPath=${workspaceFolder}",
+				"${workspaceFolder}/test/fixtures/yarn-pnp"
+			],
+			"outFiles": ["${workspaceFolder}/out/**/*.js"],
+			"preLaunchTask": "npm: dev",
+			"sourceMapRenames": true
 		}
 	]
 }

src/binary-finder.ts

@@ -194,7 +194,7 @@ const yarnPnpStrategy: LocatorStrategy = {
 		});
 
 		for (const extension of ["cjs", "js"]) {
-			const yarnPnpFile = Uri.file(`${path}/.pnp.${extension}`);
+			const yarnPnpFile = Uri.joinPath(path, `.pnp.${extension}`);
 
 			if (!(await fileExists(yarnPnpFile))) {
 				continue;
@@ -212,9 +212,11 @@ const yarnPnpStrategy: LocatorStrategy = {
 					continue;
 				}
 
-				return yarnPnpApi.resolveRequest(
-					`${platformSpecificNodePackageName}/${platformSpecificBinaryName}`,
-					biomePackage,
+				return Uri.file(
+					yarnPnpApi.resolveRequest(
+						`${platformSpecificNodePackageName}/${platformSpecificBinaryName}`,
+						biomePackage,
+					) as string,
 				);
 			} catch {
 				return undefined;

test/fixtures/yarn-pnp/.gitignore

@@ -0,0 +1,13 @@
+.yarn/*
+!.yarn/patches
+!.yarn/plugins
+!.yarn/releases
+!.yarn/sdks
+!.yarn/versions
+
+# Swap the comments on the following lines if you wish to use zero-installs
+# In that case, don't forget to run `yarn config set enableGlobalCache false`!
+# Documentation here: https://yarnpkg.com/features/caching#zero-installs
+
+#!.yarn/cache
+.pnp.*

test/fixtures/yarn-pnp/README.md

@@ -0,0 +1,17 @@
+# Yarn PnP
+
+This folder contains an example single-root workspace used as a test fixture for
+the Biome extension. The workspace folder is setup as a yarn pnp project.
+
+## Expectations
+
+When the workspace folder is opened in VS Code, the Biome extension should be active
+and used the `biome.json` configuration file at the root of the workspace folder.
+
+## Test protocol
+
+1. Open the workspace in VS Code.
+2. Run command `yarn`
+3. Open the `index.js` file.
+4. Run the `Format Document with...` command, and select the Biome extension.
+5. Verify that the document gets formatted with `indentWidth` set to `2`. and `indentStyle` set to `space`.

test/fixtures/yarn-pnp/biome.json

@@ -0,0 +1 @@
+{}

test/fixtures/yarn-pnp/index.js

@@ -0,0 +1 @@
+const a = 1;

test/fixtures/yarn-pnp/package.json

@@ -0,0 +1,8 @@
+{
+	"name": "foo",
+	"version": "0.0.0",
+	"packageManager": "[email protected]",
+	"devDependencies": {
+		"@biomejs/biome": "1.8.3"
+	}
+}