Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: broken Yarn PnP binary finder strategy #391

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: broken Yarn PnP binary finder strategy #391

wants to merge 4 commits into from
+60 −4

Conversation

Wroud
Copy link

@Wroud Wroud commented Oct 10, 2024

Summary

Fix resolving binaries with Yarn PnP mode

Checklist

  • I have tested my changes on the following platforms:
    • Windows
    • Linux
    • macOS

@Wroud Wroud requested review from nhedger and a team as code owners October 10, 2024 17:03
@Wroud Wroud changed the title Fix Yarn PnP & pre-commit command fix: yarn pnp and pre-commit hooks Oct 10, 2024
@nhedger nhedger changed the title fix: yarn pnp and pre-commit hooks fix: broken Yarn PnP binary finder strategy Oct 11, 2024
ematipico
ematipico reviewed Oct 11, 2024
View reviewed changes
lefthook.yaml Outdated Show resolved Hide resolved
test/fixtures/yarn-pnp/README.md Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ematipico ematipico ematipico left review comments

@nhedger nhedger Awaiting requested review from nhedger nhedger is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Wroud @ematipico @nhedger