Skip to content

fix: HX-Trigger with null event detail no longer throws #4136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Lluczel wants to merge 1 commit into
base: four-dev
Choose a base branch
from
Open

fix: HX-Trigger with null event detail no longer throws #4136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/htmx.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -866,7 +866,7 @@ var htmx = (() => {
if (detail?.target) {
target = this.find(detail.target);
}
this.trigger(target, name, typeof detail === 'object' ? detail : {value: detail});
this.trigger(target, name, detail !== null && typeof detail === 'object' ? detail : {value: detail});
}
} else {
value.split(',').forEach(name => this.trigger(elt, name.trim(), {}));
Expand Down
10 changes: 10 additions & 0 deletions test/tests/unit/__handleTriggerHeader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,16 @@ describe('__handleTriggerHeader unit tests', function() {
assert.equal(eventDetail.value, 42)
})

it('wraps null detail in value property', function () {
let eventDetail = undefined
let container = createProcessedHTML('<div></div>')
container.addEventListener('myEvent', (e) => { eventDetail = e.detail })

htmx.__handleTriggerHeader('{"myEvent": null}', container)

assert.isNull(eventDetail.value)
})

it('works with hx-on listeners using from:body', function () {
let root = createProcessedHTML(`
<div>
Expand Down