Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
An
HX-Triggerresponse header whose event detail isnull, e.g.HX-Trigger: {"myEvent": null}, throwsTypeError: Cannot read properties of null (reading 'cancelled'), and the event is never dispatched.__handleTriggerHeaderdecides whether to pass the detail through as-is withtypeof detail === 'object'. Sincetypeof null === 'object',nullis passed straight totrigger(). Itsdetail = {}default only applies toundefined, so!detail.cancelledthrows.This change excludes
nullfrom the pass-through branch, so it is wrapped like any other non-object value ({value: null}), the same way{"myEvent": 42}becomes{value: 42}. Object details and the comma-separated string form are unchanged.The issue suggests a guard in
trigger()instead. I kept the fix where the header is parsed for two reasons: a header-suppliednullthen follows the existing rule for non-object details (handlers readevent.detail.value), and the publictrigger()API stays untouched. Happy to add a guard there as well if you'd prefer.Corresponding issue: #4135
Closes #4135
Testing
wraps null detail in value propertytotest/tests/unit/__handleTriggerHeader.js. It fails onfour-devwith theTypeErrorabove and passes with this change.npm test(Chromium): 1781 passed, 0 failed, 4 skipped.python3 src/scripts/content/check.py: OK.Checklist
masterfor website changes,devforsource changes) (targeting
four-dev, since this is an htmx 4 source fix)approved via an issue
npm run test) and verified that it succeeded