feat(core): default to local image component #1710
Conversation
🦋 Changeset detectedLatest commit: 27fcdb6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
chanceaclark
force-pushed
the
feat/default-bc-image
branch
from
10ee507 to
ac366d3
Compare
There was a problem hiding this comment.
I'll need to throw a PR up for https://www.catalyst.dev/docs/cdn-and-images.
| if (height) { | ||
| url = src.replace('{:size}', `${width}x${height}`); | ||
| } |
There was a problem hiding this comment.
Height isn't actually supported by the image loader, so opted to remove.
| interface BcImageOptions { | ||
| lossy?: boolean; | ||
| } |
There was a problem hiding this comment.
Lossy is done through the API now, so we can omit this prop.
chanceaclark
changed the title
chanceaclark
force-pushed
the
feat/default-bc-image
branch
from
ac366d3 to
27fcdb6
Compare
|
Do we want to merge this into |
Can we just do a rebase onto |
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-3uaamzui1-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
What/Why?
I attempted to try and use the
images.loaderFilefromnext.config.tsbut there are some internals that Next.js does with the build to replace all references to the default loader import. This causes infinite loops trying to import the definedloaderFile.The PR makes the default image component
CatalystImagewhich uses the default loader as a fallback.BcImagewas renamed toCatalystImage.Testing