fix: import Image instead of BcImage #1719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
|
jorgemoya
force-pushed
the
fix-image-imports
branch
from
bbb028a to
c5b80a7
Compare
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-i8lo3zklg-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
deini
approved these changes
Dec 9, 2024
chanceaclark
approved these changes
Dec 9, 2024
migueloller
pushed a commit
that referenced
this pull request
Dec 10, 2024
jorgemoya
added a commit
that referenced
this pull request
Dec 12, 2024
jorgemoya
added a commit
that referenced
this pull request
Dec 12, 2024
jorgemoya
added a commit
that referenced
this pull request
Jan 3, 2025
jorgemoya
added a commit
that referenced
this pull request
Jan 3, 2025
jorgemoya
added a commit
that referenced
this pull request
Jan 7, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 10, 2025
* chore(core): use next canary and enable ppr * fix: use suggested functions over deprecated ones * chore(core): update tailwind config and layout to use Soul config * fix: eslint issues * chore(core): add roboto mono font * chore(core): add @/vibes/* path in tsconfig * feat(core): add FeaturedProductsList component and use in Homepage (#1673) * feat(core): add FeaturedProductsCarousel and use in Homepage (#1675) * feat(core): add best selling products to Hompage (#1676) * chore: bump components to include latest Streamable util (#1681) * chore(core): use next canary and enable ppr * feat: replace catalyst homepage slideshow * refactor: updated slideshow structure based on PR feedback * feat: add translations for homepage slider * fix: slide not in view when element inside is focused (#1687) * chore(core): use next canary and enable ppr * fix: use suggested functions over deprecated ones * chore(core): update tailwind config and layout to use Soul config * fix: eslint issues * chore(core): add roboto mono font * chore(core): add @/vibes/* path in tsconfig * feat(core): add FeaturedProductsList component and use in Homepage (#1673) * feat(core): add FeaturedProductsCarousel and use in Homepage (#1675) * feat(core): add best selling products to Hompage (#1676) * chore: bump components to include latest Streamable util (#1681) * chore(core): use next canary and enable ppr * feat: replace catalyst homepage slideshow * refactor: updated slideshow structure based on PR feedback * feat: add translations for homepage slider * fix: slide not in view when element inside is focused --------- Co-authored-by: Jorge Moya <[email protected]> * feat: add header (#1702) * feat: add soul SignInSection * refactor: ErrorMessage -> FieldError * feat: add form status * feat: add error message for sign in * fix: remove nextjs internals for redirect error handling * fix: add back metadata request locale * feat: add footer with streamable sitemap links (#1698) * fix: import Image instead of BcImage (#1719) * fix: form status bg color * feat: update forgot password to soul * refactor: nest lastResult in forgotPassword action * fix: inline recaptcha fragment in ResetPageQuery * feat: remove bestselling products from Home (#1725) * feat(core): add subscribe form to Homepage (#1682) * feat: stream in products for carousel/featured in Home (#1726) * feat: add empty state to FeaturedProductsCarousel (#1731) * chore: run pnpm lint -- --fix (#1736) * fix: bump VIBES components and pass in accessibility props in Home (#1739) * feat: add empty state for FeatureProductsList (#1745) * feat: add logout route handler * feat: add dynamic form primitive * feat: update sign up form to soul * fix: lint issues * fix: register customer required fields * refactor: use zod to parse register customer input * fix: sync dynamic form with VIBES * fix: remove quantity from dynamic form * fix: htmlFor in groups * feat: update Breadcrumbs to use AnimatedLink and new skeleton design (#1754) * feat: update change password to SOUL * feat: update button props and variables * feat: add search functionality to header * fix: change quick search param name to "term" This matches what the search page expects. * chore: bring in latest VIBES changes * feat: use header search translated error message * feat: don't attempt to search if less than 3 chars * chore: bring in latest VIBES changes * feat: better i18n for header search * feat(soul): add account layout components * chore: remove static pages (#1762) * chore: remove edge runtime from pages (#1763) * chore: bring in latet VIBES changes * feat: use Soul in category page * feat: add imagePriority prop to ProductCard (#1767) * fix: move font variables to html element * feat: add props and css variables for slideshow * feat: add props and css variables for carousel * feat: add CSS variables to ProductCard * chore: sync navigation primitive with VIBES * chore: add Makeswift team to CODEOWNERS * feat: add BlogPostContent to blog/[id] page * refactor: move default css variables into Accordion * refactor: move default css variables into Button, ButtonLink * refactor: move default css variables into Carousel * refactor: move default css variables into Slideshow * feat: add props to ProductsCarousel * feat(core): add account settings soul components * feat: add FeaturedBlogPostList to /blog * feat: add variables to Navigation * feat: add variables to StickySidebarLayout * feat: add props to ProductList * feat: add variables to banner/header * feat: use FeaturedBlogPostList in /blog/tag/ route * feat: add footer variables and logo * feat: add localized contact title * feat: add ProductDetails to PDP (#1751) * fix: section max width * feat: add pagination and breadcrumbs to /blog and /blog/tag/[tagId] * feat: refactor ProductListSection breadcrumbs * feat: sync breadcrumbs and implementations with vibes * feat: undo ProductListSection breadcrumb change to ensure it's not displayed for 1 breadcrumb * feat: update pageInfoTransformer * feat: add related products to PDP (#1788) * feat: add reviews to PDP (#1786) * fix: ensure page info transformer returns null if no previous/next page * feat: add product description to PDP (#1790) * feat: Soul ProductsListSection for search results * feat: add support for custom blog url routing, update blog tag filtering, delete /blog/tag/[tagId] route * feat: add empty state to BlogPostList * refactor: move app fonts from the root layout to their own file * feat: update /blog/[blogId] route to use skeleton and streamable props * feat: use Soul in brand page * refactor: move search params cache to category page * refactor: move search params cache to search page * feat: Add NotFound section to 404 page * fix: aria-label and placeholder in Select * fix: pass placeholder prop from ProductsListSection into Sorting * fix: rendering or label and placeholder props * chore: bring latest ProducstListSection from VIBES * feat: add height prop to Logo * feat: add FeaturedProductsCarousel to 404 page * fix: use grid for pdp specifications * fix: reduce gap on pdp * chore: bring in latest changes from Soul VIBE * feat: handle localization for new PLP labels * fix: facets transformer range input mapping * feat: add cart from VIBES * feat: replace cart with VIBES cart * fix: remove empty string in value (#1832) * chore: bring in latest changes from VIBES * feat: show sub-categories * chore: revert nextjs (#1840) * fix: remove regression tests workflow (#1843) * feat: add Error page and ErrorBoundary * feat(orders): update the orders list to use vibes section * chore: remove unused files in facet pages (#1838) * fix: add missing labels to number input (#1855) * chore: upgrade next to 15.1.1-canary.26 Next.js renamed expireTag and expirePath to unstable_ * chore: add changeset (#1853) * chore: remove unused components in /components (#1866) * chore: remove store selector page that is no longer being used (#1868) * chore: remove /cart-quantity route that is no longer being used (#1869) * chore: remove unused components in /blog (#1867) * chore: remove @bigcommerce/makeswift group from codeowners (#1872) * fix: don't pass `{}` to `createSearchParamsCache` * chore: upgrade next to 15.2.0-canary.1 This release contain fixes for 404 revalidation issue with revalidateTag bug. * feat(core): update order details page with VIBES * refactor(core): remove product path fetching in favor of line item path * fix: use lazy promise on getCartCount to defer cookies() execution This fixes 500 error: needs to bail out of prerendering at this point because it used cookies() Without the lazy promise, the getCartCount() is immediately executed, and calls cookies(). With lazy promise, the getCartCount() execution is deferred, until await/then is used. * feat(core): update address list to use VIBES * feat(core): add country list to account addresses * Add down for maintenance page * fix: accessibility issues in PDP (#1877) * Add Web Pages * chore: bring in latest changes from VIBES * fix: add hideOverflow to sections and carousels * fix: use SectionLayout in FeaturedProductCarousel * fix: use SectionLayout in FeaturedBlogList --------- Co-authored-by: Hunter Garrett <[email protected]> Co-authored-by: Alan Pledger <[email protected]> Co-authored-by: Miguel Oller <[email protected]> Co-authored-by: Chancellor Clark <[email protected]> Co-authored-by: Miguel Oller <[email protected]> Co-authored-by: Daniel Almaguer <[email protected]> Co-authored-by: jordanarldt <[email protected]> Co-authored-by: Aleksey Gurtovoy <[email protected]> Co-authored-by: Fikri Karim <[email protected]>
BC-krasnoshapka
pushed a commit
that referenced
this pull request
Jan 23, 2025
* chore(core): use next canary and enable ppr * fix: use suggested functions over deprecated ones * chore(core): update tailwind config and layout to use Soul config * fix: eslint issues * chore(core): add roboto mono font * chore(core): add @/vibes/* path in tsconfig * feat(core): add FeaturedProductsList component and use in Homepage (#1673) * feat(core): add FeaturedProductsCarousel and use in Homepage (#1675) * feat(core): add best selling products to Hompage (#1676) * chore: bump components to include latest Streamable util (#1681) * chore(core): use next canary and enable ppr * feat: replace catalyst homepage slideshow * refactor: updated slideshow structure based on PR feedback * feat: add translations for homepage slider * fix: slide not in view when element inside is focused (#1687) * chore(core): use next canary and enable ppr * fix: use suggested functions over deprecated ones * chore(core): update tailwind config and layout to use Soul config * fix: eslint issues * chore(core): add roboto mono font * chore(core): add @/vibes/* path in tsconfig * feat(core): add FeaturedProductsList component and use in Homepage (#1673) * feat(core): add FeaturedProductsCarousel and use in Homepage (#1675) * feat(core): add best selling products to Hompage (#1676) * chore: bump components to include latest Streamable util (#1681) * chore(core): use next canary and enable ppr * feat: replace catalyst homepage slideshow * refactor: updated slideshow structure based on PR feedback * feat: add translations for homepage slider * fix: slide not in view when element inside is focused --------- Co-authored-by: Jorge Moya <[email protected]> * feat: add header (#1702) * feat: add soul SignInSection * refactor: ErrorMessage -> FieldError * feat: add form status * feat: add error message for sign in * fix: remove nextjs internals for redirect error handling * fix: add back metadata request locale * feat: add footer with streamable sitemap links (#1698) * fix: import Image instead of BcImage (#1719) * fix: form status bg color * feat: update forgot password to soul * refactor: nest lastResult in forgotPassword action * fix: inline recaptcha fragment in ResetPageQuery * feat: remove bestselling products from Home (#1725) * feat(core): add subscribe form to Homepage (#1682) * feat: stream in products for carousel/featured in Home (#1726) * feat: add empty state to FeaturedProductsCarousel (#1731) * chore: run pnpm lint -- --fix (#1736) * fix: bump VIBES components and pass in accessibility props in Home (#1739) * feat: add empty state for FeatureProductsList (#1745) * feat: add logout route handler * feat: add dynamic form primitive * feat: update sign up form to soul * fix: lint issues * fix: register customer required fields * refactor: use zod to parse register customer input * fix: sync dynamic form with VIBES * fix: remove quantity from dynamic form * fix: htmlFor in groups * feat: update Breadcrumbs to use AnimatedLink and new skeleton design (#1754) * feat: update change password to SOUL * feat: update button props and variables * feat: add search functionality to header * fix: change quick search param name to "term" This matches what the search page expects. * chore: bring in latest VIBES changes * feat: use header search translated error message * feat: don't attempt to search if less than 3 chars * chore: bring in latest VIBES changes * feat: better i18n for header search * feat(soul): add account layout components * chore: remove static pages (#1762) * chore: remove edge runtime from pages (#1763) * chore: bring in latet VIBES changes * feat: use Soul in category page * feat: add imagePriority prop to ProductCard (#1767) * fix: move font variables to html element * feat: add props and css variables for slideshow * feat: add props and css variables for carousel * feat: add CSS variables to ProductCard * chore: sync navigation primitive with VIBES * chore: add Makeswift team to CODEOWNERS * feat: add BlogPostContent to blog/[id] page * refactor: move default css variables into Accordion * refactor: move default css variables into Button, ButtonLink * refactor: move default css variables into Carousel * refactor: move default css variables into Slideshow * feat: add props to ProductsCarousel * feat(core): add account settings soul components * feat: add FeaturedBlogPostList to /blog * feat: add variables to Navigation * feat: add variables to StickySidebarLayout * feat: add props to ProductList * feat: add variables to banner/header * feat: use FeaturedBlogPostList in /blog/tag/ route * feat: add footer variables and logo * feat: add localized contact title * feat: add ProductDetails to PDP (#1751) * fix: section max width * feat: add pagination and breadcrumbs to /blog and /blog/tag/[tagId] * feat: refactor ProductListSection breadcrumbs * feat: sync breadcrumbs and implementations with vibes * feat: undo ProductListSection breadcrumb change to ensure it's not displayed for 1 breadcrumb * feat: update pageInfoTransformer * feat: add related products to PDP (#1788) * feat: add reviews to PDP (#1786) * fix: ensure page info transformer returns null if no previous/next page * feat: add product description to PDP (#1790) * feat: Soul ProductsListSection for search results * feat: add support for custom blog url routing, update blog tag filtering, delete /blog/tag/[tagId] route * feat: add empty state to BlogPostList * refactor: move app fonts from the root layout to their own file * feat: update /blog/[blogId] route to use skeleton and streamable props * feat: use Soul in brand page * refactor: move search params cache to category page * refactor: move search params cache to search page * feat: Add NotFound section to 404 page * fix: aria-label and placeholder in Select * fix: pass placeholder prop from ProductsListSection into Sorting * fix: rendering or label and placeholder props * chore: bring latest ProducstListSection from VIBES * feat: add height prop to Logo * feat: add FeaturedProductsCarousel to 404 page * fix: use grid for pdp specifications * fix: reduce gap on pdp * chore: bring in latest changes from Soul VIBE * feat: handle localization for new PLP labels * fix: facets transformer range input mapping * feat: add cart from VIBES * feat: replace cart with VIBES cart * fix: remove empty string in value (#1832) * chore: bring in latest changes from VIBES * feat: show sub-categories * chore: revert nextjs (#1840) * fix: remove regression tests workflow (#1843) * feat: add Error page and ErrorBoundary * feat(orders): update the orders list to use vibes section * chore: remove unused files in facet pages (#1838) * fix: add missing labels to number input (#1855) * chore: upgrade next to 15.1.1-canary.26 Next.js renamed expireTag and expirePath to unstable_ * chore: add changeset (#1853) * chore: remove unused components in /components (#1866) * chore: remove store selector page that is no longer being used (#1868) * chore: remove /cart-quantity route that is no longer being used (#1869) * chore: remove unused components in /blog (#1867) * chore: remove @bigcommerce/makeswift group from codeowners (#1872) * fix: don't pass `{}` to `createSearchParamsCache` * chore: upgrade next to 15.2.0-canary.1 This release contain fixes for 404 revalidation issue with revalidateTag bug. * feat(core): update order details page with VIBES * refactor(core): remove product path fetching in favor of line item path * fix: use lazy promise on getCartCount to defer cookies() execution This fixes 500 error: needs to bail out of prerendering at this point because it used cookies() Without the lazy promise, the getCartCount() is immediately executed, and calls cookies(). With lazy promise, the getCartCount() execution is deferred, until await/then is used. * feat(core): update address list to use VIBES * feat(core): add country list to account addresses * Add down for maintenance page * fix: accessibility issues in PDP (#1877) * Add Web Pages * chore: bring in latest changes from VIBES * fix: add hideOverflow to sections and carousels * fix: use SectionLayout in FeaturedProductCarousel * fix: use SectionLayout in FeaturedBlogList --------- Co-authored-by: Hunter Garrett <[email protected]> Co-authored-by: Alan Pledger <[email protected]> Co-authored-by: Miguel Oller <[email protected]> Co-authored-by: Chancellor Clark <[email protected]> Co-authored-by: Miguel Oller <[email protected]> Co-authored-by: Daniel Almaguer <[email protected]> Co-authored-by: jordanarldt <[email protected]> Co-authored-by: Aleksey Gurtovoy <[email protected]> Co-authored-by: Fikri Karim <[email protected]>
kathir-arizon
pushed a commit
to Arizon-Digital/catalyst-cuts-metal
that referenced
this pull request
Feb 4, 2025
* chore(core): use next canary and enable ppr * fix: use suggested functions over deprecated ones * chore(core): update tailwind config and layout to use Soul config * fix: eslint issues * chore(core): add roboto mono font * chore(core): add @/vibes/* path in tsconfig * feat(core): add FeaturedProductsList component and use in Homepage (bigcommerce#1673) * feat(core): add FeaturedProductsCarousel and use in Homepage (bigcommerce#1675) * feat(core): add best selling products to Hompage (bigcommerce#1676) * chore: bump components to include latest Streamable util (bigcommerce#1681) * chore(core): use next canary and enable ppr * feat: replace catalyst homepage slideshow * refactor: updated slideshow structure based on PR feedback * feat: add translations for homepage slider * fix: slide not in view when element inside is focused (bigcommerce#1687) * chore(core): use next canary and enable ppr * fix: use suggested functions over deprecated ones * chore(core): update tailwind config and layout to use Soul config * fix: eslint issues * chore(core): add roboto mono font * chore(core): add @/vibes/* path in tsconfig * feat(core): add FeaturedProductsList component and use in Homepage (bigcommerce#1673) * feat(core): add FeaturedProductsCarousel and use in Homepage (bigcommerce#1675) * feat(core): add best selling products to Hompage (bigcommerce#1676) * chore: bump components to include latest Streamable util (bigcommerce#1681) * chore(core): use next canary and enable ppr * feat: replace catalyst homepage slideshow * refactor: updated slideshow structure based on PR feedback * feat: add translations for homepage slider * fix: slide not in view when element inside is focused --------- Co-authored-by: Jorge Moya <[email protected]> * feat: add header (bigcommerce#1702) * feat: add soul SignInSection * refactor: ErrorMessage -> FieldError * feat: add form status * feat: add error message for sign in * fix: remove nextjs internals for redirect error handling * fix: add back metadata request locale * feat: add footer with streamable sitemap links (bigcommerce#1698) * fix: import Image instead of BcImage (bigcommerce#1719) * fix: form status bg color * feat: update forgot password to soul * refactor: nest lastResult in forgotPassword action * fix: inline recaptcha fragment in ResetPageQuery * feat: remove bestselling products from Home (bigcommerce#1725) * feat(core): add subscribe form to Homepage (bigcommerce#1682) * feat: stream in products for carousel/featured in Home (bigcommerce#1726) * feat: add empty state to FeaturedProductsCarousel (bigcommerce#1731) * chore: run pnpm lint -- --fix (bigcommerce#1736) * fix: bump VIBES components and pass in accessibility props in Home (bigcommerce#1739) * feat: add empty state for FeatureProductsList (bigcommerce#1745) * feat: add logout route handler * feat: add dynamic form primitive * feat: update sign up form to soul * fix: lint issues * fix: register customer required fields * refactor: use zod to parse register customer input * fix: sync dynamic form with VIBES * fix: remove quantity from dynamic form * fix: htmlFor in groups * feat: update Breadcrumbs to use AnimatedLink and new skeleton design (bigcommerce#1754) * feat: update change password to SOUL * feat: update button props and variables * feat: add search functionality to header * fix: change quick search param name to "term" This matches what the search page expects. * chore: bring in latest VIBES changes * feat: use header search translated error message * feat: don't attempt to search if less than 3 chars * chore: bring in latest VIBES changes * feat: better i18n for header search * feat(soul): add account layout components * chore: remove static pages (bigcommerce#1762) * chore: remove edge runtime from pages (bigcommerce#1763) * chore: bring in latet VIBES changes * feat: use Soul in category page * feat: add imagePriority prop to ProductCard (bigcommerce#1767) * fix: move font variables to html element * feat: add props and css variables for slideshow * feat: add props and css variables for carousel * feat: add CSS variables to ProductCard * chore: sync navigation primitive with VIBES * chore: add Makeswift team to CODEOWNERS * feat: add BlogPostContent to blog/[id] page * refactor: move default css variables into Accordion * refactor: move default css variables into Button, ButtonLink * refactor: move default css variables into Carousel * refactor: move default css variables into Slideshow * feat: add props to ProductsCarousel * feat(core): add account settings soul components * feat: add FeaturedBlogPostList to /blog * feat: add variables to Navigation * feat: add variables to StickySidebarLayout * feat: add props to ProductList * feat: add variables to banner/header * feat: use FeaturedBlogPostList in /blog/tag/ route * feat: add footer variables and logo * feat: add localized contact title * feat: add ProductDetails to PDP (bigcommerce#1751) * fix: section max width * feat: add pagination and breadcrumbs to /blog and /blog/tag/[tagId] * feat: refactor ProductListSection breadcrumbs * feat: sync breadcrumbs and implementations with vibes * feat: undo ProductListSection breadcrumb change to ensure it's not displayed for 1 breadcrumb * feat: update pageInfoTransformer * feat: add related products to PDP (bigcommerce#1788) * feat: add reviews to PDP (bigcommerce#1786) * fix: ensure page info transformer returns null if no previous/next page * feat: add product description to PDP (bigcommerce#1790) * feat: Soul ProductsListSection for search results * feat: add support for custom blog url routing, update blog tag filtering, delete /blog/tag/[tagId] route * feat: add empty state to BlogPostList * refactor: move app fonts from the root layout to their own file * feat: update /blog/[blogId] route to use skeleton and streamable props * feat: use Soul in brand page * refactor: move search params cache to category page * refactor: move search params cache to search page * feat: Add NotFound section to 404 page * fix: aria-label and placeholder in Select * fix: pass placeholder prop from ProductsListSection into Sorting * fix: rendering or label and placeholder props * chore: bring latest ProducstListSection from VIBES * feat: add height prop to Logo * feat: add FeaturedProductsCarousel to 404 page * fix: use grid for pdp specifications * fix: reduce gap on pdp * chore: bring in latest changes from Soul VIBE * feat: handle localization for new PLP labels * fix: facets transformer range input mapping * feat: add cart from VIBES * feat: replace cart with VIBES cart * fix: remove empty string in value (bigcommerce#1832) * chore: bring in latest changes from VIBES * feat: show sub-categories * chore: revert nextjs (bigcommerce#1840) * fix: remove regression tests workflow (bigcommerce#1843) * feat: add Error page and ErrorBoundary * feat(orders): update the orders list to use vibes section * chore: remove unused files in facet pages (bigcommerce#1838) * fix: add missing labels to number input (bigcommerce#1855) * chore: upgrade next to 15.1.1-canary.26 Next.js renamed expireTag and expirePath to unstable_ * chore: add changeset (bigcommerce#1853) * chore: remove unused components in /components (bigcommerce#1866) * chore: remove store selector page that is no longer being used (bigcommerce#1868) * chore: remove /cart-quantity route that is no longer being used (bigcommerce#1869) * chore: remove unused components in /blog (bigcommerce#1867) * chore: remove @bigcommerce/makeswift group from codeowners (bigcommerce#1872) * fix: don't pass `{}` to `createSearchParamsCache` * chore: upgrade next to 15.2.0-canary.1 This release contain fixes for 404 revalidation issue with revalidateTag bug. * feat(core): update order details page with VIBES * refactor(core): remove product path fetching in favor of line item path * fix: use lazy promise on getCartCount to defer cookies() execution This fixes 500 error: needs to bail out of prerendering at this point because it used cookies() Without the lazy promise, the getCartCount() is immediately executed, and calls cookies(). With lazy promise, the getCartCount() execution is deferred, until await/then is used. * feat(core): update address list to use VIBES * feat(core): add country list to account addresses * Add down for maintenance page * fix: accessibility issues in PDP (bigcommerce#1877) * Add Web Pages * chore: bring in latest changes from VIBES * fix: add hideOverflow to sections and carousels * fix: use SectionLayout in FeaturedProductCarousel * fix: use SectionLayout in FeaturedBlogList --------- Co-authored-by: Hunter Garrett <[email protected]> Co-authored-by: Alan Pledger <[email protected]> Co-authored-by: Miguel Oller <[email protected]> Co-authored-by: Chancellor Clark <[email protected]> Co-authored-by: Miguel Oller <[email protected]> Co-authored-by: Daniel Almaguer <[email protected]> Co-authored-by: jordanarldt <[email protected]> Co-authored-by: Aleksey Gurtovoy <[email protected]> Co-authored-by: Fikri Karim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why?
Fix for #1710.
Testing
CI passes.