refactor(core): update submit create account errors message #1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
🦋 Changeset detectedLatest commit: 501aec9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bc-alexsaiannyi
force-pushed
the
update-create-account-errors-message
branch
from
5748c49 to
b254990
Compare
bc-alexsaiannyi
force-pushed
the
update-create-account-errors-message
branch
from
b254990 to
fd1efa8
Compare
chanceaclark
reviewed
Dec 3, 2024
core/app/[locale]/(default)/(auth)/register/_actions/register-customer.ts
Outdated
Show resolved
Hide resolved
chanceaclark
approved these changes
Dec 5, 2024
bc-alexsaiannyi
force-pushed
the
update-create-account-errors-message
branch
from
9237e7f to
5a83f6d
Compare
Merged
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-ehaxhc268-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why?
This PR adds helper for submit error messages for
create-accountform with aim to extend it further on other account related forms. As a result we have a list with separated submit errors.Testing
locally
create-account-error-list.mov