Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update account forms submit errors message #1649

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

bc-alexsaiannyi
Copy link
Contributor

What/Why?

This PR utilizes PR for improving create-account submit error message and extends it on other account forms.

Testing

locally

Screenshot 2024-11-18 at 12 42 04

Copy link

changeset-bot bot commented Nov 18, 2024

🦋 Changeset detected

Latest commit: ab616d1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@bigcommerce/catalyst-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 8:44pm
catalyst-soul 🛑 Canceled (Inspect) Dec 9, 2024 8:44pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Dec 9, 2024 8:44pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Dec 9, 2024 8:44pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Dec 9, 2024 8:44pm
catalyst-unstable ⬜️ Ignored (Inspect) Dec 9, 2024 8:44pm

@chanceaclark chanceaclark added this pull request to the merge queue Dec 9, 2024
Merged via the queue into main with commit d38f164 Dec 9, 2024
11 of 16 checks passed
@chanceaclark chanceaclark deleted the update-account-forms-error-message branch December 9, 2024 20:56
@github-actions github-actions bot mentioned this pull request Dec 9, 2024
Copy link
Contributor

github-actions bot commented Dec 9, 2024

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-cssyod03d-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟠 Performance 78
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟠 Performance 88
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants