Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOTFIX] pipeline failing without id_only because of missing outputs #382

Merged
merged 1 commit into from
Jul 3, 2024
Merged

[HOTFIX] pipeline failing without id_only because of missing outputs #382

merged 1 commit into from
Jul 3, 2024

Conversation

jpfeuffer
Copy link
Collaborator

@jpfeuffer jpfeuffer commented Jul 3, 2024 •
edited
Loading

I'm wondering how the tests in the id_only PR could pass but I am pretty sure that is a bug.
I cannot get a DIANN workflow to work without this.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/quantms branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nf-test test main.nf.test -profile test,docker).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 5097c9b

+| ✅ 292 tests passed       |+
#| ❔   4 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • nfcore_yml - nf-core version not set in .nf-core.yml

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-07-03 13:59:27

@jpfeuffer jpfeuffer requested a review from ypriverol July 3, 2024 14:30
@jpfeuffer jpfeuffer merged commit ee788b4 into dev Jul 3, 2024
16 of 18 checks passed
@jpfeuffer jpfeuffer deleted the hotfix/missingout_idonly branch July 3, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ypriverol ypriverol Awaiting requested review from ypriverol

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jpfeuffer