BRP `world.list_components` doesn't work for non-entity specified

[Zeophlite]

Bevy version and features

• main

What you did

• in terminal 1 run cargo run --example server --features="bevy_remote"
• in terminal 2 run curl -d'{"jsonrpc":"2.0","method":"world.list_components","id":1,"params":{"entity":null}}' -X POST -H "Accept: applcation/json" -H "Content-Type: application/json" http://127.0.0.1:15702
• also tried with "params":{}

What went wrong

• Got response {"jsonrpc":"2.0","id":1,"error":{"code":-32602,"message":"invalid type: null, expected u64"}} and {"jsonrpc":"2.0","id":1,"error":{"code":-32602,"message":"missing field entity"}}
• Expected to get a list of all registered components, as per

  bevy/crates/bevy_remote/src/builtin_methods.rs

  Line 1319 in fd0e08a

  // If `None`, list all registered components.

[kfc35]

I can test this later, but from the comment for BrpListComponentsParams:

/// `world.list_components`: Returns a list of all type names of registered components in the
/// system (no params provided), or those on an entity (params provided).

I would interpret this as params itself needing to be null or undefined, not the entity within the params being null

[kfc35]

curl -d'{"jsonrpc":"2.0","method":"world.list_components","id":1,"params":null}' -X POST -H "Accept: applcation/json" -H "Content-Type: application/json" http://127.0.0.1:15702

results in a valid response - params must be null

(as an additional test point curl -d'{"jsonrpc":"2.0","method":"world.list_components","id":1}' -X POST -H "Accept: applcation/json" -H "Content-Type: application/json" http://127.0.0.1:15702 does not return a valid response)

I would not consider this issue a bug, but a question of docs / whether we want to improve the usability of that endpoint

[kfc35]

I opened a PR for the undefined case since it’s a regression #23661

But yeah, I would not consider ”params”: {} or ”params”: { “entity”: null}} to be valid ways to query a “no params provided” endpoint. In both cases, technically params were provided as an object. I would nominate to close this