Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raycasting for primitives. #13618

Open
1 of 7 tasks
Olle-Lukowski opened this issue Jun 1, 2024 · 4 comments · May be fixed by #15724
Open
1 of 7 tasks

Raycasting for primitives. #13618

Olle-Lukowski opened this issue Jun 1, 2024 · 4 comments · May be fixed by #15724
Assignees
@Olle-Lukowski
Labels
A-Math Fundamental domain-agnostic mathematical operations C-Feature A new feature, making something new possible D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes S-Needs-Review Needs reviewer attention (from anyone!) to move forward
Milestone
0.16

Comments

@Olle-Lukowski
Copy link
Contributor

Olle-Lukowski commented Jun 1, 2024 •
edited
Loading

I have recently started working on https://github.com/Olle-Lukowski/bevy_contrib_raycast to allow for raycasts on both 2d and 3d primitives. I thought I would open up a tracking issue here, so more people can review / help out with the code.

Here is a checklist of what needs to be done:

  • Implement RayCast2d for all 2D primitives (quick and dirty, to get a working example)
  • Implement RayCast3d for all 3D primitives (quick and dirty, to get a working example)
  • Optimize and clean up 2D impls.
  • Optimize and clean up 3D impls.
  • Add tests.
  • Write some docs.
  • Get reviews, fix any issues.
@Olle-Lukowski Olle-Lukowski added C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled labels Jun 1, 2024
@alice-i-cecile alice-i-cecile added A-Math Fundamental domain-agnostic mathematical operations and removed S-Needs-Triage This issue needs to be labelled labels Jun 1, 2024
@janhohenheim
Copy link
Member

janhohenheim commented Sep 27, 2024 •
edited
Loading

@alice-i-cecile should we close this in favor of #12365 ?

@alice-i-cecile
Copy link
Member

IMO no: this issue is more specific and still desired. The other issue is largely complete though.

@alice-i-cecile alice-i-cecile added the S-Needs-Help The author needs help finishing this PR. label Sep 27, 2024
@BenjaminBrienen BenjaminBrienen self-assigned this Sep 27, 2024
@BenjaminBrienen BenjaminBrienen added the D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes label Sep 28, 2024
@BenjaminBrienen
Copy link
Contributor

BenjaminBrienen commented Sep 29, 2024 •
edited
Loading

I have implemented for cuboid with tests
Olle-Lukowski/bevy_contrib_raycast#2

@BenjaminBrienen BenjaminBrienen linked a pull request Oct 10, 2024 that will close this issue
Draft
@Jondolf
Copy link
Contributor

Jondolf commented Oct 10, 2024

Implemented everything in #15724 :)

I'll most likely split it into several smaller PRs over the 0.16 cycle.

@alice-i-cecile alice-i-cecile added S-Needs-Review Needs reviewer attention (from anyone!) to move forward and removed S-Needs-Help The author needs help finishing this PR. labels Oct 10, 2024
@alice-i-cecile alice-i-cecile added this to the 0.16 milestone Oct 10, 2024
@BenjaminBrienen BenjaminBrienen removed their assignment Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Olle-Lukowski Olle-Lukowski

Labels
A-Math Fundamental domain-agnostic mathematical operations C-Feature A new feature, making something new possible D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes S-Needs-Review Needs reviewer attention (from anyone!) to move forward
Projects
None yet
Milestone
0.16
Development

Successfully merging a pull request may close this issue.

Ray Casting for Primitive Shapes Jondolf/bevy
5 participants
@alice-i-cecile @janhohenheim @BenjaminBrienen @Jondolf @Olle-Lukowski