Add cmake workflow presets #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernedom
reviewed
Aug 20, 2023
bernedom
requested changes
Sep 22, 2023
| @@ -0,0 +1,55 @@ | |||
| --- | |||
There was a problem hiding this comment.
please remove this file from the commit as it contains user specific configuration
There was a problem hiding this comment.
Die you see the bugprone-use-after-move comments?
I hoped you use it to fix this errors.
There was a problem hiding this comment.
I confess I haven't run clang tidy in a long time on the code. But thanks for the hint, will have a look
There was a problem hiding this comment.
With clang-17 the are much more Warnungen.
Also upgrade to catch2 v3.4.0 to use Catch2WithMain. Add intermeediate header for now.
Suppress more clang-tidy-17 warnings too
bernedom
approved these changes
Oct 29, 2023
Quickfix for OSX CI build problems. Prevent to build ctests while version-consistency tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.