Skip to content

Commit

Permalink
Changes according review
Browse files Browse the repository at this point in the history
Suppress more clang-tidy-7 warnings too
  • Loading branch information
ClausKlein committed Oct 27, 2023
1 parent 5a05b44 commit 562df08
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 6 deletions.
11 changes: 10 additions & 1 deletion .clang-tidy
Original file line number Diff line number Diff line change
Expand Up @@ -14,23 +14,32 @@ Checks:
concurrency-*,
#MAYBE google-*,
hicpp-*,
-hicpp-explicit-conversions,
misc-*,
-misc-const-correctness,
-misc-include-cleaner,
modernize-*,
-modernize-type-traits,
-modernize-use-nodiscard,
-modernize-use-trailing-return-type,
performance-*,
portability-*,
readability-*,
-readability-identifier-naming,
-readability-identifier-length,
-readability-simplify-boolean-expr,
-readability-string-compare,
-*-magic-numbers,
-*-narrowing-conversions,
-*-uppercase-literal-suffix,
'

HeaderFilterRegex: '.*'
WarningsAsErrors: 'clang*'
FormatStyle: google
UseColor: false
User: klein_cl

#MAYBE: ... example only
CheckOptions:
- { key: readability-identifier-naming.NamespaceCase, value: CamelCase }
- { key: readability-identifier-naming.ClassCase, value: CamelCase }
Expand Down
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.23)
cmake_minimum_required(VERSION 3.23...3.27)

project(
"SI"
Expand Down
8 changes: 4 additions & 4 deletions test/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ cmake_minimum_required(VERSION 3.23)
add_executable(SI_detail_tests)
target_sources(
SI_detail_tests
PRIVATE #XXX src/Catch2Main.cc
PRIVATE
src/detail_tests/detail_tests.cc
src/detail_tests/number_parser_tests.cc
src/detail_tests/unit_t_operator_tests.cc
Expand Down Expand Up @@ -33,7 +33,7 @@ target_compile_options(
add_executable(SI_base_unit_tests)
target_sources(
SI_base_unit_tests
PRIVATE #XXX src/Catch2Main.cc
PRIVATE
src/base_unit_tests/mass_tests.cc
src/base_unit_tests/time_tests.cc
src/base_unit_tests/electric_current_tests.cc
Expand Down Expand Up @@ -68,7 +68,7 @@ target_compile_options(
add_executable(SI_derived_unit_tests)
target_sources(
SI_derived_unit_tests
PRIVATE #XXX src/Catch2Main.cc
PRIVATE
src/derived_unit_tests/area_tests.cc
src/derived_unit_tests/frequency_tests.cc
src/derived_unit_tests/electric_charge_tests.cc
Expand Down Expand Up @@ -121,7 +121,7 @@ target_compile_options(
add_executable(SI_unit_benchmarks)
target_sources(
SI_unit_benchmarks
PRIVATE #XXX src/Catch2Main.cc
PRIVATE
src/benchmarks/unit_assignment_benchmarks.cc
src/benchmarks/detail_benchmarks.cc
src/benchmarks/string_operations_benchmarks.cc)
Expand Down
File renamed without changes.

0 comments on commit 562df08

Please sign in to comment.