Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add comment and remove _SELF #142

Merged
merged 1 commit into from
Aug 19, 2024
Merged

add comment and remove _SELF #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions contracts/Nexus.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,14 +64,11 @@ contract Nexus is INexus, BaseAccount, ExecutionHelper, ModuleManager, UUPSUpgra
/// - An EIP-712 hash: keccak256("\x19\x01" || someDomainSeparator || hashStruct(someStruct))
bytes32 private constant _MESSAGE_TYPEHASH = keccak256("BiconomyNexusMessage(bytes32 hash)");

address private immutable _SELF;

/// @dev `keccak256("PersonalSign(bytes prefixed)")`.
bytes32 internal constant _PERSONAL_SIGN_TYPEHASH = 0x983e65e5148e570cd828ead231ee759a8d7958721a768f93bc4483ba005c32de;

/// @notice Initializes the smart account with the specified entry point.
constructor(address anEntryPoint) {
_SELF = address(this);
require(address(anEntryPoint) != address(0), EntryPointCanNotBeZero());
_ENTRYPOINT = anEntryPoint;
_initModuleManager();
Expand Down
2 changes: 2 additions & 0 deletions contracts/base/ExecutionHelper.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ contract ExecutionHelper is IExecutionHelperEventsAndErrors {
using ExecLib for bytes;

/// @notice Executes a call to a target address with specified value and data.
/// @dev calls to an EOA should be counted as successful.
/// @param target The address to execute the call on.
/// @param value The amount of wei to send with the call.
/// @param callData The calldata to send.
Expand All @@ -54,6 +55,7 @@ contract ExecutionHelper is IExecutionHelperEventsAndErrors {

/// @notice Tries to execute a call and captures if it was successful or not.
/// @dev Similar to _execute but returns a success boolean and catches reverts instead of propagating them.
/// @dev calls to an EOA should be counted as successful.
/// @param target The address to execute the call on.
/// @param value The amount of wei to send with the call.
/// @param callData The calldata to send.
Expand Down
Loading