Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add comment and remove _SELF #142

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

livingrockrises
Copy link
Contributor

No description provided.

Copy link

🤖 Slither Analysis Report 🔎

Slither report

# Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary
🟡 - locked-ether (1 results) (Medium)

locked-ether

🟡 Impact: Medium
🔴 Confidence: High

utils/RegistryBootstrap.sol#L33-L165

constable-states

Impact: Optimization
🔴 Confidence: High

base/RegistryAdapter.sol#L12

factory/RegistryFactory.sol#L39

_This comment was automatically generated by the GitHub Actions workflow._

Copy link

add comment and remove _SELF

Generated at commit: 84c09410ae15d719d9721ca6d615ea8977b231b0

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
0
1
0
7
24
32

For more details view the full report in OpenZeppelin Code Inspector

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.49%. Comparing base (80d3913) to head (84c0941).
Report is 38 commits behind head on remediations/cantina-spearbit.

Additional details and impacted files
@@                        Coverage Diff                        @@
##           remediations/cantina-spearbit     #142      +/-   ##
=================================================================
+ Coverage                          72.19%   75.49%   +3.30%     
=================================================================
  Files                                 13       13              
  Lines                                694      657      -37     
  Branches                             150      126      -24     
=================================================================
- Hits                                 501      496       -5     
+ Misses                               193      161      -32     
Files Coverage Δ
contracts/Nexus.sol 62.85% <ø> (-0.22%) ⬇️
contracts/base/ExecutionHelper.sol 56.38% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0070740...84c0941. Read the comment docs.

@livingrockrises livingrockrises merged commit 850f67a into remediations/cantina-spearbit Aug 19, 2024
8 of 10 checks passed
@livingrockrises livingrockrises deleted the fix/low-issues branch August 19, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants