Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linting only - 'venv/bin/isort --profile black --atomic -l 100 graphk… #111

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

dustinbleile
Copy link
Contributor

linting only:

venv/bin/isort --profile black --atomic -l 100 graphkb/ tests/ *.py

venv/bin/black -C --line-length 100 graphkb/ tests/ *.py'

…b/ tests/ *.py & venv/bin/black -C --line-length 100 graphkb/ tests/ *.py'
Copy link

codecov bot commented Dec 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.30%. Comparing base (73473c6) to head (3e3a4c2).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #111      +/-   ##
===========================================
+ Coverage    89.52%   91.30%   +1.78%     
===========================================
  Files            8        8              
  Lines          840      840              
===========================================
+ Hits           752      767      +15     
+ Misses          88       73      -15     
Flag Coverage Δ
unittests 91.30% <100.00%> (+1.78%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elewis2
Copy link
Collaborator

elewis2 commented Dec 5, 2023

I wonder about using -S to preserve single quotes here?

@dustinbleile
Copy link
Contributor Author

I wonder about using -S to preserve single quotes here?

Hi @elewis2,
I don't think we've been fully consistent, so I think we should just go to the general standard and not worry about it further.

1 similar comment
@dustinbleile
Copy link
Contributor Author

I wonder about using -S to preserve single quotes here?

Hi @elewis2,
I don't think we've been fully consistent, so I think we should just go to the general standard and not worry about it further.

@dustinbleile
Copy link
Contributor Author

Hi @elewis2,
Any further comments? Are you really sure you want to keep single quotes in some places?

@elewis2
Copy link
Collaborator

elewis2 commented Feb 29, 2024

Hi @elewis2, Any further comments? Are you really sure you want to keep single quotes in some places?

No, no serious objection, especially if we haven't been consistent anyway

elewis2
elewis2 previously approved these changes Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants