Add set_k function to miBf #139
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parham-k
approved these changes
May 10, 2025
parham-k
reviewed
May 10, 2025
tests/python/test_mi_bloom_filter.py
Outdated
| def set_up_mi_bf_1(self): | ||
|
|
||
| self.mi_bf_1 = btllib.MIBloomFilter8(1024 * 1024, 3, "ntHash") | ||
| self.mi_bf_1.set_k() = 10 |
Member
There was a problem hiding this comment.
I think this should be self.mi_bf_1.set_k(10)?
Member
Author
There was a problem hiding this comment.
thanks for spotting that. That is strange, the test didn't fail locally. Maybe I didn't save before running
parham-k
reviewed
May 10, 2025
azure-pipelines.yml
Outdated
| source activate btllib_CI | ||
| conda install --yes -c conda-forge mamba | ||
| mamba install --yes -c conda-forge -c bioconda libcxx compilers clang llvm clang-format=18 clang-tools boost samtools coreutils xz lrzip meson ninja cmake openmp | ||
| mamba install --yes -c conda-forge -c bioconda libcxx compilers clang llvm clang-format=18 clang-tools boost samtools coreutils xz lrzip meson ninja cmake<4 openmp |
Member
There was a problem hiding this comment.
'cmake<4' (in single quotes) should resolve the issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.