Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a mechanism to provide a list of protocol names for constant value extraction. #1170

Merged
merged 16 commits into from
May 17, 2024
Merged

Add a mechanism to provide a list of protocol names for constant value extraction. #1170

merged 16 commits into from
May 17, 2024

Commits on May 16, 2024

  1. Add a mechanism to provide a list of protocol names for constant valu… 

    …e extraction.

If a module populates `const_gather_protocols` when calling `create_swift_module_context`, any target that directly depends on that module will automatically have that list of protocols passed to the compiler via `-const-gather-protocols-file`. The output group `const_values` will then contain the JSON file with the extracted constant information.

This is meant to support Apple's AppIntents framework, which uses the output from `-emit-const-values-path` as an input to the AppIntent bundling tool.

PiperOrigin-RevId: 588388131
(cherry picked from commit 18f2f87)
    @allevato @BalestraPatrick
    allevato authored and BalestraPatrick committed May 16, 2024
    Configuration menu
    Copy the full SHA
    7ad545b View commit details
    Browse the repository at this point in the history

  2. Fixes

    @BalestraPatrick
    BalestraPatrick committed May 16, 2024
    Configuration menu
    Copy the full SHA
    a191c7d View commit details
    Browse the repository at this point in the history

  3. Update docs

    @BalestraPatrick
    BalestraPatrick committed May 16, 2024
    Configuration menu
    Copy the full SHA
    c10cc40 View commit details
    Browse the repository at this point in the history

  4. Run buildifier

    @BalestraPatrick
    BalestraPatrick committed May 16, 2024
    Configuration menu
    Copy the full SHA
    1facdf8 View commit details
    Browse the repository at this point in the history

  5. Add private feature

    @BalestraPatrick
    BalestraPatrick committed May 16, 2024
    Configuration menu
    Copy the full SHA
    6273abd View commit details
    Browse the repository at this point in the history

  6. Fix buildifier

    @BalestraPatrick
    BalestraPatrick committed May 16, 2024
    Configuration menu
    Copy the full SHA
    4ef9b96 View commit details
    Browse the repository at this point in the history

  7. Update docs

    @BalestraPatrick
    BalestraPatrick committed May 16, 2024
    Configuration menu
    Copy the full SHA
    18d3264 View commit details
    Browse the repository at this point in the history

  8. Small fixes

    @keith @BalestraPatrick
    keith authored and BalestraPatrick committed May 16, 2024
    Configuration menu
    Copy the full SHA
    c6b9a11 View commit details
    Browse the repository at this point in the history

  9. Change minimum Xcode version for const value extraction to 15.0

    @BalestraPatrick
    BalestraPatrick committed May 16, 2024
    Configuration menu
    Copy the full SHA
    2aeb7c6 View commit details
    Browse the repository at this point in the history

  10. Refactor file creation logic to derived_files.bzl

    @BalestraPatrick
    BalestraPatrick committed May 16, 2024
    Configuration menu
    Copy the full SHA
    7f092c6 View commit details
    Browse the repository at this point in the history

  11. Move const_extract_protocol.json to static file in toolchain

    @BalestraPatrick
    BalestraPatrick committed May 16, 2024
    Configuration menu
    Copy the full SHA
    9034980 View commit details
    Browse the repository at this point in the history

  12. Add const_vaues tests

    @BalestraPatrick
    BalestraPatrick committed May 16, 2024
    Configuration menu
    Copy the full SHA
    a806419 View commit details
    Browse the repository at this point in the history

  13. Disable some tests on Linux given the older Swift version

    @BalestraPatrick
    BalestraPatrick committed May 16, 2024
    Configuration menu
    Copy the full SHA
    7c2e1ce View commit details
    Browse the repository at this point in the history

  14. Fix conflict resolution

    @BalestraPatrick
    BalestraPatrick committed May 16, 2024
    Configuration menu
    Copy the full SHA
    be307b2 View commit details
    Browse the repository at this point in the history

  15. Update docs and fix buildifier failure

    @BalestraPatrick
    BalestraPatrick committed May 16, 2024
    Configuration menu
    Copy the full SHA
    aad53d8 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. Fix review comments

    @BalestraPatrick
    BalestraPatrick committed May 17, 2024
    Configuration menu
    Copy the full SHA
    c2fde06 View commit details
    Browse the repository at this point in the history