Add a mechanism to provide a list of protocol names for constant value extraction. #1170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BalestraPatrick
force-pushed
the
constant-value-extraction
branch
3 times, most recently
from
cbf792b
to
a3529d0
Compare
BalestraPatrick
commented
Feb 27, 2024
|
what's the general progress on this? |
|
I just verified this seems to be working in our project together with bazelbuild/rules_apple#2418 |
BalestraPatrick
requested review from
brentleyjones,
luispadron,
mattrobmattrob and
thii
as code owners
keith
reviewed
Mar 1, 2024
BalestraPatrick
force-pushed
the
constant-value-extraction
branch
6 times, most recently
from
b179ff3
to
cc6abe8
Compare
|
@keith There were no tests upstream, but I tried my best at adding some. I also had to disable them on Linux due to the fact that we're using Swift 5.7 there, and from what I can see support for the flags we're using started in Swift 5.8. |
|
When testing this internally with a remote cache I'm getting Edit: removing our usage of |
…e extraction. If a module populates `const_gather_protocols` when calling `create_swift_module_context`, any target that directly depends on that module will automatically have that list of protocols passed to the compiler via `-const-gather-protocols-file`. The output group `const_values` will then contain the JSON file with the extracted constant information. This is meant to support Apple's AppIntents framework, which uses the output from `-emit-const-values-path` as an input to the AppIntent bundling tool. PiperOrigin-RevId: 588388131 (cherry picked from commit 18f2f87)
BalestraPatrick
force-pushed
the
constant-value-extraction
branch
from
cc6abe8
to
be307b2
Compare
BalestraPatrick
force-pushed
the
constant-value-extraction
branch
from
2bd5d82
to
aad53d8
Compare
luispadron
approved these changes
May 17, 2024
keith
approved these changes
May 17, 2024
BalestraPatrick
referenced
this pull request
May 17, 2024
…e extraction. If a module populates `const_gather_protocols` when calling `create_swift_module_context`, any target that directly depends on that module will automatically have that list of protocols passed to the compiler via `-const-gather-protocols-file`. The output group `const_values` will then contain the JSON file with the extracted constant information. This is meant to support Apple's AppIntents framework, which uses the output from `-emit-const-values-path` as an input to the AppIntent bundling tool. PiperOrigin-RevId: 588388131
brentleyjones
pushed a commit
to bazelbuild/rules_apple
that referenced
this pull request
Jul 10, 2024
Depends on bazelbuild/rules_swift#1170 --------- Co-authored-by: Nicholas Levin <[email protected]> Co-authored-by: Patrick Balestra <[email protected]> Co-authored-by: Luis Padron <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cherry-picks support for producing const values produced via the compiler flags
-emit-const-values-pathand-const-gather-protocols-file. rules_apple will start using this feature in bazelbuild/rules_apple#2418.