Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of proc macro deps with multiple kinds #2211

Merged
merged 5 commits into from
Oct 25, 2023
Merged

Fix handling of proc macro deps with multiple kinds #2211

merged 5 commits into from
Oct 25, 2023

Commits on Oct 24, 2023

  1. Fix handling of proc macro deps with multiple kinds 

    A proc macro dependency may have multiple kinds such as build
and normal. Due to a bug in filtering predicate, such dependencies
are considered only as build dependency.

This PR fixes the bug and adds a regression test.

Issue: bazelbuild#2210
    @ulan
    ulan committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    faf4196 View commit details
    Browse the repository at this point in the history

  2. Add missing test files

    @ulan
    ulan committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    00ebad1 View commit details
    Browse the repository at this point in the history

  3. Remove reference to local dirs

    @ulan
    ulan committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    2794371 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. Add an assertion about build script deps

    @ulan
    ulan committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    920acb7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix-2210

    @UebelAndre
    UebelAndre authored Oct 25, 2023
    Configuration menu
    Copy the full SHA
    fa5ef8e View commit details
    Browse the repository at this point in the history