Fix handling of proc macro deps with multiple kinds #2211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A proc macro dependency may have multiple kinds such as build and normal. Due to a bug in filtering predicate, such dependencies are considered only as build dependency. This PR fixes the bug and adds a regression test. Issue: bazelbuild#2210
|
@UebelAndre could you please take a look? Thanks! |
UebelAndre
requested changes
Oct 25, 2023
|
@UebelAndre thanks for merging! Do you know approximately when the next version that includes this fix will be released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A proc macro dependency may have multiple kinds such as build
and normal. Due to a bug in filtering predicate, such dependencies
are considered only as build dependency.
This PR fixes the bug and adds a regression test.
Issue: #2210