Improvements to better support cxx #2192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Support adding to `deps` from annotations in Cargo.toml files * Default `extra_aliased_targets` and `gen_binaries` to `None` rather than empty collections, because the rust code has explicit handling for `None` vs empty when merging.
UebelAndre
approved these changes
Oct 12, 2023
This was referenced Oct 12, 2023
UebelAndre
pushed a commit
that referenced
this pull request
Oct 14, 2023
This eliminates the annotation introduced by #2192, because it includes dtolnay/cxx#1277. This PR includes handwritten changes to WORKSPACE.bazel followed by the generated result of running: - `cd examples/crate_universe/using_cxx` - `CARGO_BAZEL_REPIN=1 bazel sync --only=using_cxx` - `CARGO_BAZEL_REPIN=1 bazel sync --only=cxxbridge_cmd_deps` Tested by running `bazel build ...` in the same directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depsfrom annotations in Cargo.toml filesextra_aliased_targetsandgen_binariestoNonerather than empty collections, because the rust code has explicit handling forNonevs empty when merging.