Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: Add dependency on cxx_cc via annotation #1277

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

illicitonion
Copy link
Contributor

@illicitonion illicitonion commented Oct 12, 2023

Copy link
Owner

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay dtolnay merged commit 35f61b3 into dtolnay:master Oct 12, 2023
16 checks passed
@dtolnay
Copy link
Owner

dtolnay commented Oct 12, 2023

Published in 1.0.109.

@illicitonion illicitonion deleted the bazel-cxx-lib-dep branch October 13, 2023 09:25
UebelAndre pushed a commit to bazelbuild/rules_rust that referenced this pull request Oct 14, 2023
This eliminates the annotation introduced by
#2192, because it includes
dtolnay/cxx#1277.

This PR includes handwritten changes to WORKSPACE.bazel followed by the
generated result of running:

- `cd examples/crate_universe/using_cxx`
- `CARGO_BAZEL_REPIN=1 bazel sync --only=using_cxx`
- `CARGO_BAZEL_REPIN=1 bazel sync --only=cxxbridge_cmd_deps`

Tested by running `bazel build ...` in the same directory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants