Add support for macos in apple_*_xcframework rules
#2459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luispadron
commented
May 26, 2024
Comment on lines
+869
to
+871
| "macos": attr.string_list( | ||
| doc = """ | ||
| A list of strings indicating which architecture should be built for the macOS platform (for example, `x86_64`, `arm64`). |
There was a problem hiding this comment.
Keeping this a string_list_dict keeps the logic simpler, and maybe we just fail if folks pass simulator?
luispadron
force-pushed
the
luis/add-support-for-macos-xcframeworks
branch
from
d8a3282
to
83af71b
Compare
luispadron
changed the title
apple_*_xcframework rules
luispadron
force-pushed
the
luis/add-support-for-macos-xcframeworks
branch
6 times, most recently
from
df2c4f8
to
a330f7f
Compare
luispadron
commented
May 26, 2024
Comment on lines
+35
to
+36
| if split_deps_key in deps: | ||
| all_deps += deps[split_deps_key] |
There was a problem hiding this comment.
@keith @brentleyjones this fixes an issue introduced by adding the macos attr to apple_static_xcframework:
ERROR: /Users/lpadron/Development/rules_apple/test/starlark_tests/targets_under_test/apple/BUILD:942:25: in apple_static_xcframework rule //test/starlark_tests/targets_under_test/apple:ios_static_xcframework_with_resources:
Traceback (most recent call last):
File "/Users/lpadron/Development/rules_apple/apple/internal/xcframework_rules.bzl", line 943, column 83, in _apple_static_xcframework_impl
link_outputs_by_library_identifier = _group_link_outputs_by_library_identifier(
File "/Users/lpadron/Development/rules_apple/apple/internal/xcframework_rules.bzl", line 205, column 45, in _group_link_outputs_by_library_identifier
if swift_support.uses_swift(deps[split_attr_key]):
Error: key "ios_arm64e_device" not found in dictionary
How should we properly fix this? Is the apple_rule_arm64_as_arm64e_transition being applied here for some reason?
There was a problem hiding this comment.
This still leaves us with:
ERROR: /Users/lpadron/Development/rules_apple/test/starlark_tests/targets_under_test/apple/BUILD:508:8: declared output 'test/starlark_tests/targets_under_test/apple/ios_xcframework_bundling_static_fmwks.xcframework/ios-arm64_x86_64-simulator/ios_xcframework_bundling_static_fmwks.framework/Headers/ios_xcframework_bundling_static_fmwks.h' was not created by genrule. This is probably because the genrule actually didn't create this output, or because the output was a directory and the genrule was run remotely (note that only the contents of declared file outputs are copied from genrules run remotely)
There was a problem hiding this comment.
AFAICT adding macos changes the transitions to add arm64e, maybe this is related to #2419 as well since that's a split deps issue as well.
luispadron
force-pushed
the
luis/add-support-for-macos-xcframeworks
branch
from
a330f7f
to
113bdd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1475. Adds a new
macosattr to theapple_*_frameworkrules which allow setting the architectures to build a macOS binary for.