-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XCFramework for macOS #1475
Comments
OK, I see how I can implement this. I'll work on PR. |
Is there a follow-up? |
I'd also like this so if anyone is already working on this let me know otherwise I'll likely spend some time to get this working for macOS |
I get the following output when examining the split transition keys used here:
|
I've got something in draft now that generates the expected XCFramework: #2459 |
luispadron
added a commit
that referenced
this issue
Sep 14, 2024
This commit adds a `macos` attr to both the `apple_xcframework` and `apple_static_xcframework` rules. This allows building for multiple architectures and platforms. The new `macos` attr is a `string_list` (unlike the `ios` attr which is a dict for the simulator/device split). Example: ```starlark apple_xcframework( name = "ios_and_macos_dynamic_xcframework", bundle_id = "com.google.example", extension_safe = True, infoplists = [ "//test/starlark_tests/resources:Info.plist", ], ios = { "simulator": ["x86_64"], "device": ["arm64"], }, macos = [ "arm64", "x86_64", ], minimum_os_versions = { "ios": common.min_os_ios.baseline, "macos": common.min_os_macos.baseline, }, public_hdrs = [ "//test/starlark_tests/resources:shared.h", ], tags = common.fixture_tags, deps = [":fmwk_lib"], ) ``` Fixes #1475
luispadron
added a commit
that referenced
this issue
Sep 14, 2024
This commit adds a `macos` attr to both the `apple_xcframework` and `apple_static_xcframework` rules. This allows building for multiple architectures and platforms. The new `macos` attr is a `string_list` (unlike the `ios` attr which is a dict for the simulator/device split). Example: ```starlark apple_xcframework( name = "ios_and_macos_dynamic_xcframework", bundle_id = "com.google.example", extension_safe = True, infoplists = [ "//test/starlark_tests/resources:Info.plist", ], ios = { "simulator": ["x86_64"], "device": ["arm64"], }, macos = [ "arm64", "x86_64", ], minimum_os_versions = { "ios": common.min_os_ios.baseline, "macos": common.min_os_macos.baseline, }, public_hdrs = [ "//test/starlark_tests/resources:shared.h", ], tags = common.fixture_tags, deps = [":fmwk_lib"], ) ``` Fixes #1475
luispadron
added a commit
that referenced
this issue
Sep 14, 2024
This commit adds a `macos` attr to both the `apple_xcframework` and `apple_static_xcframework` rules. This allows building for multiple architectures and platforms. The new `macos` attr is a `string_list` (unlike the `ios` attr which is a dict for the simulator/device split). Example: ```starlark apple_xcframework( name = "ios_and_macos_dynamic_xcframework", bundle_id = "com.google.example", extension_safe = True, infoplists = [ "//test/starlark_tests/resources:Info.plist", ], ios = { "simulator": ["x86_64"], "device": ["arm64"], }, macos = [ "arm64", "x86_64", ], minimum_os_versions = { "ios": common.min_os_ios.baseline, "macos": common.min_os_macos.baseline, }, public_hdrs = [ "//test/starlark_tests/resources:shared.h", ], tags = common.fixture_tags, deps = [":fmwk_lib"], ) ``` Fixes #1475
luispadron
added a commit
that referenced
this issue
Oct 10, 2024
This commit adds a `macos` attr to both the `apple_xcframework` and `apple_static_xcframework` rules. This allows building for multiple architectures and platforms. The new `macos` attr is a `string_list` (unlike the `ios` attr which is a dict for the simulator/device split). Example: ```starlark apple_xcframework( name = "ios_and_macos_dynamic_xcframework", bundle_id = "com.google.example", extension_safe = True, infoplists = [ "//test/starlark_tests/resources:Info.plist", ], ios = { "simulator": ["x86_64"], "device": ["arm64"], }, macos = [ "arm64", "x86_64", ], minimum_os_versions = { "ios": common.min_os_ios.baseline, "macos": common.min_os_macos.baseline, }, public_hdrs = [ "//test/starlark_tests/resources:shared.h", ], tags = common.fixture_tags, deps = [":fmwk_lib"], ) ``` Fixes #1475
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello!
Is there a way to create XCFramework for both iOS and macOS using
apple_xcframework
?minimum_deployment_os_versions
andminimum_os_versions
attributes don't seem to work. Andios
attribute allows you to specify onlyios
architectures.The text was updated successfully, but these errors were encountered: