Fix runtime_solib_name for --incompatible_macos_set_install_name
#23089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team-Rules-CPP
This was referenced Jul 24, 2024
|
@bazel-io fork 7.3.0 |
|
The follow-up is #23090 |
|
The Darwin failure is a flake. |
The `runtime_solib_name` link variable had an incorrect value in the case of a transitive dynamic library. Since non-transitive ("nodeps") dynamic libraries are no longer used on macOS, the `--incompatible_macos_set_install_name` flag didn't have any positive effect.
This PR is intentionally limited to the fix so that it can be cherry-picked into Bazel 7, where it can make the incompatible flag work with the `apple_support` toolchain. A follow-up PR will add the feature to the Unix toolchain and flip the incompatible flag for Bazel 8.
|
@meteorcloudy The new macOS workers keep running into weird CI failures on this branch. Sometimes it's the Javac worker crashing, sometimes extraction failures such as https://buildkite.com/bazel/bazel-bazel-github-presubmit/builds/22557#0190e57f-a35c-460d-8a40-efef5a69e656. I'll avoid running new jobs for now in case CI is just overloaded. |
|
Just a friendly reminder, the 7.3.0RC1 is scheduled for next Monday, July 29th. Thanks! |
comius
requested changes
Jul 29, 2024
|
@bazel-io fork 7.4.0 |
comius
approved these changes
Aug 26, 2024
comius
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Sep 19, 2024
The `runtime_solib_name` link variable had an incorrect value in the case of a transitive dynamic library. Since non-transitive ("nodeps") dynamic libraries are no longer used on macOS, the `--incompatible_macos_set_install_name` flag didn't have any positive effect.
This PR is intentionally limited to the fix so that it can be cherry-picked into Bazel 7, where it can make the incompatible flag work with the `apple_support` toolchain. A follow-up PR will add the feature to the Unix toolchain and flip the incompatible flag for Bazel 8.
Work towards bazelbuild#12370
Closes bazelbuild#23089.
PiperOrigin-RevId: 668228562
Change-Id: I7524679bfe8c6b8b28c0cb04f46c0d22d0adbe99
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 23, 2024
…l_name` (#23672) The `runtime_solib_name` link variable had an incorrect value in the case of a transitive dynamic library. Since non-transitive ("nodeps") dynamic libraries are no longer used on macOS, the `--incompatible_macos_set_install_name` flag didn't have any positive effect. This PR is intentionally limited to the fix so that it can be cherry-picked into Bazel 7, where it can make the incompatible flag work with the `apple_support` toolchain. A follow-up PR will add the feature to the Unix toolchain and flip the incompatible flag for Bazel 8. Work towards #12370 Closes #23089. PiperOrigin-RevId: 668228562 Change-Id: I7524679bfe8c6b8b28c0cb04f46c0d22d0adbe99 Fixes #23185
|
The changes in this PR have been included in Bazel 7.4.0 RC1. Please test out the release candidate and report any issues as soon as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
runtime_solib_namelink variable had an incorrect value in the case of a transitive dynamic library. Since non-transitive ("nodeps") dynamic libraries are no longer used on macOS, the--incompatible_macos_set_install_nameflag didn't have any positive effect.This PR is intentionally limited to the fix so that it can be cherry-picked into Bazel 7, where it can make the incompatible flag work with the
apple_supporttoolchain. A follow-up PR will add the feature to the Unix toolchain and flip the incompatible flag for Bazel 8.Work towards #12370