Enable C/C++ remote tests on macOS #23085
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 24, 2024
fmeum
force-pushed
the
macos-remote-tests
branch
from
64981a9
to
de0c705
Compare
fmeum
force-pushed
the
macos-remote-tests
branch
2 times, most recently
from
8cbf76d
to
cb50edf
Compare
Support for Xcode env vars is aded to the remote worker, making it possible to run these tests.
fmeum
force-pushed
the
macos-remote-tests
branch
from
cb50edf
to
4373df9
Compare
github-actions
bot
added
team-Remote-Exec
|
FYI @keith |
|
@tjgq I have been able to drop the apple_support patch thanks to a release containing the fix, this is now ready for review. |
|
@coeuvre Could you help getting this merged? It just adds test coverage. |
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also ensure that the remote worker doesn't fail executions when the spawn fails, but instead sends back the result of the unsuccessful execution.