-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix runtime_solib_name
for --incompatible_macos_set_install_name
#23089
Conversation
@bazel-io fork 7.3.0 |
The follow-up is #23090 |
The Darwin failure is a flake. |
The `runtime_solib_name` link variable had an incorrect value in the case of a transitive dynamic library. Since non-transitive ("nodeps") dynamic libraries are no longer used on macOS, the `--incompatible_macos_set_install_name` flag didn't have any positive effect. This PR is intentionally limited to the fix so that it can be cherry-picked into Bazel 7, where it can make the incompatible flag work with the `apple_support` toolchain. A follow-up PR will add the feature to the Unix toolchain and flip the incompatible flag for Bazel 8.
@meteorcloudy The new macOS workers keep running into weird CI failures on this branch. Sometimes it's the Javac worker crashing, sometimes extraction failures such as https://buildkite.com/bazel/bazel-bazel-github-presubmit/builds/22557#0190e57f-a35c-460d-8a40-efef5a69e656. I'll avoid running new jobs for now in case CI is just overloaded. |
Just a friendly reminder, the 7.3.0RC1 is scheduled for next Monday, July 29th. Thanks! |
@bazel-io fork 7.4.0 |
The `runtime_solib_name` link variable had an incorrect value in the case of a transitive dynamic library. Since non-transitive ("nodeps") dynamic libraries are no longer used on macOS, the `--incompatible_macos_set_install_name` flag didn't have any positive effect. This PR is intentionally limited to the fix so that it can be cherry-picked into Bazel 7, where it can make the incompatible flag work with the `apple_support` toolchain. A follow-up PR will add the feature to the Unix toolchain and flip the incompatible flag for Bazel 8. Work towards bazelbuild#12370 Closes bazelbuild#23089. PiperOrigin-RevId: 668228562 Change-Id: I7524679bfe8c6b8b28c0cb04f46c0d22d0adbe99
…l_name` (#23672) The `runtime_solib_name` link variable had an incorrect value in the case of a transitive dynamic library. Since non-transitive ("nodeps") dynamic libraries are no longer used on macOS, the `--incompatible_macos_set_install_name` flag didn't have any positive effect. This PR is intentionally limited to the fix so that it can be cherry-picked into Bazel 7, where it can make the incompatible flag work with the `apple_support` toolchain. A follow-up PR will add the feature to the Unix toolchain and flip the incompatible flag for Bazel 8. Work towards #12370 Closes #23089. PiperOrigin-RevId: 668228562 Change-Id: I7524679bfe8c6b8b28c0cb04f46c0d22d0adbe99 Fixes #23185
The changes in this PR have been included in Bazel 7.4.0 RC1. Please test out the release candidate and report any issues as soon as possible. |
The
runtime_solib_name
link variable had an incorrect value in the case of a transitive dynamic library. Since non-transitive ("nodeps") dynamic libraries are no longer used on macOS, the--incompatible_macos_set_install_name
flag didn't have any positive effect.This PR is intentionally limited to the fix so that it can be cherry-picked into Bazel 7, where it can make the incompatible flag work with the
apple_support
toolchain. A follow-up PR will add the feature to the Unix toolchain and flip the incompatible flag for Bazel 8.Work towards #12370