Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch third_party/grpc from deprecated cfg = "host" to cfg = "exec" #19192

Closed
wants to merge 1 commit into from
Closed

Switch third_party/grpc from deprecated cfg = "host" to cfg = "exec" #19192

wants to merge 1 commit into from

Conversation

tetromino
Copy link
Contributor

@tetromino tetromino commented Aug 7, 2023 •
edited
Loading

Removes a blocker for building Bazel itself with --incompatible_disable_starlark_host_transition (#17032) - and unblocks bazelbuild/stardoc#145

Also, take the opportunity to remove the long-unused grpc 1.41.0 patch.

@tetromino
Switch third_party/grpc from deprecated cfg = "host" to cfg = "exec"
2dc3ff3 
Removes a blocker for buildimg Bazel itself with --incompatible_disable_starlark_host_transition -
and unblocks bazelbuild/stardoc#145
@tetromino tetromino requested a review from meteorcloudy August 7, 2023 15:33
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Aug 7, 2023
@tetromino tetromino added the team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. label Aug 7, 2023
@tetromino tetromino mentioned this pull request Aug 7, 2023
Closed
meteorcloudy
meteorcloudy approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Aug 8, 2023
copybara-service bot pushed a commit that referenced this pull request Aug 8, 2023
@tetromino @Pavank1992
Switch third_party/grpc from deprecated cfg = "host" to cfg = "exec"
1f15b87 
Removes a blocker for buildimg Bazel itself with --incompatible_disable_starlark_host_transition -
and unblocks bazelbuild/stardoc#145

Partial commit for third_party/*, see #19192.

Signed-off-by: Pavan Singh <[email protected]>
@Pavank1992
Copy link
Contributor

Third party changes merged here: 1f15b87

@Pavank1992 Pavank1992 closed this Aug 8, 2023
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Aug 8, 2023
@meteorcloudy
Copy link
Member

meteorcloudy commented Aug 8, 2023 •
edited
Loading

@Pavank1992 third_party/grpc is actually checked in google3, you should have merged this one with the google3 approach.

Sorry, I was wrong, third_party/grpc is not in google3, this PR is merged correctly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorcloudy meteorcloudy meteorcloudy approved these changes

Assignees
No one assigned
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tetromino @Pavank1992 @meteorcloudy